Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use "all" for pipenv install #699

Closed
wants to merge 2 commits into from
Closed

Conversation

rokroskar
Copy link
Member

updates Pipfile and Pipfile.lock to include packages required for testing.

@rokroskar rokroskar requested a review from a team as a code owner September 20, 2019 12:13
Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be that we hook up deps updates on the release pipeline? Doing this manually seems a bit too repetitive.

@rokroskar
Copy link
Member Author

probably not impossible, but I will rerun it with --keep-outdated - then it won't update any libraries, only add new ones.

@rokroskar
Copy link
Member Author

Hmm so apparently this doesn't quite work as expected - the packages still got updated

@Panaetius
Copy link
Member

Hmm so apparently this doesn't quite work as expected - the packages still got updated

Apparently --ignore-pipfile --keep-outdated would work, just using Pipfile.lock for installing. Alternatively pipenv sync --dev should also work.

Have you thought about using pyup ? I think it supports pipenv, though there might still be some issues with pipenv support as it's relatively new (Difficult to tell from the docs/issues how mature it is). Automated PRs for dependency updates would be nice, though.

@rokroskar
Copy link
Member Author

rokroskar commented Sep 25, 2019

Apparently --ignore-pipfile --keep-outdated would work, just using Pipfile.lock for installing. Alternatively pipenv sync --dev should also work.

not sure this is really ideal either - --ignore-pipfile just ends up with an empty Pipfile.lock where the only dependency is .[all]. I guess I could do

pipenv install --dev .[all]

which would should leave the non-dev packages untouched.

@rokroskar
Copy link
Member Author

well apparently this results in a strange situation where none of the development dependencies actually appear in the Pipfile.lock, but they are installed. And it still modifies some of the non-dev packages. I give up.

Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold, until we manually test refactorings and tags.

@jsam jsam added the on hold label Oct 8, 2019
@jsam jsam closed this Oct 10, 2019
@jsam jsam deleted the 000-update-pipfile branch October 10, 2019 13:14
@jsam jsam mentioned this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants