fix: use commit author for project creator #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokroskar
force-pushed
the
713-wrong-project-creator
branch
2 times, most recently
from
d1f0d05
to
9a43b0e
Compare
rokroskar
changed the title
rokroskar
force-pushed
the
713-wrong-project-creator
branch
2 times, most recently
from
603f091
to
0b57195
Compare
m-alisafaee
requested changes
Oct 1, 2019
jsam
suggested changes
Oct 1, 2019
rokroskar
force-pushed
the
713-wrong-project-creator
branch
2 times, most recently
from
4a09800
to
d7b9261
Compare
rokroskar
force-pushed
the
713-wrong-project-creator
branch
from
d7b9261
to
f36f0ed
Compare
jsam
approved these changes
Oct 2, 2019
m-alisafaee
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR corrects the wrong behavior that the user executing the git command was being set as the project creator. Instead, if the project creator does not exist, the git history of
.renku/metadata.ymlis searched for the first commit and its author is used as the project creator.closes #713