Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remember projects that are just ids (#2316) #2408

Merged
merged 1 commit into from Mar 8, 2023
Merged

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Mar 8, 2023

Fix #2316

/deploy #persist #cypress renku=renku-ui-3.4.0-tests

@ciyer ciyer requested a review from a team as a code owner March 8, 2023 10:05
@ciyer ciyer temporarily deployed to renku-ci-ui-2408 March 8, 2023 10:07 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Mar 8, 2023

You can access the deployment of this PR at https://renku-ci-ui-2408.dev.renku.ch

@ciyer ciyer deployed to renku-ci-ui-2408 March 8, 2023 12:38 — with GitHub Actions Active
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works well! I tested with a few projects and it constantly drops the numeric IDs (on the left) where before it used to store and return them (on the right).

image

@ciyer ciyer merged commit 959183d into master Mar 8, 2023
@ciyer ciyer deleted the 2316-last-projects branch March 8, 2023 13:58
@RenkuBot
Copy link
Contributor

RenkuBot commented Mar 8, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last projects showed twice
4 participants