fix(client): improve string validation when trying to upload a dataset file by URL #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
temporarily deployed
to
renku-ci-ui-2834
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2834.dev.renku.ch |
andre-code
temporarily deployed
to
renku-ci-ui-2834
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2834
GitHub Actions
Inactive
|
@andre-code Is this PR waiting for a renku-core fix? |
|
I think the renku-core requirement is not a problem anymore (renku-core 2.8.0 is out) |
lorenzo-cavazzi
had a problem deploying
to
renku-ci-ui-2834
GitHub Actions
Error
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2834
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2834
GitHub Actions
Inactive
lorenzo-cavazzi
requested changes
Jan 8, 2024
There was a problem hiding this comment.
This works fine now 👍
We can use the new function instead of the older isUrl; that's actually used only in a single other place where the new function should be more reliable. I suggest replacing the import with isValidURL and removing the older function isUrl (changing the code is also fine; I find the new name you gave to the new function more intuitive)
lorenzo-cavazzi
force-pushed
the
2801-upload-datasetfile-by-url
branch
from
787a3b1
to
eb3d218
Compare
lorenzo-cavazzi
changed the title
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2834
GitHub Actions
Inactive
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix bug when upload a dataset file by url.
Changes:
Fix #2801
/deploy extra-values=core.sentry.dsn=https://0cc02f3a02d3474d9f7e90915873ab4d@sentry.dev.renku.ch/2,core.sentry.environment=renku-dev,core.sentry.enabled=true