feat(client): redesign landing page #2925

andre-code · 2023-11-27T20:53:29Z

PR Landing page

/deploy renku=2891-get-started-section extra-values=global.renku.cli_version=2.7.0 #persist

RenkuBot · 2023-11-27T20:54:23Z

You can access the deployment of this PR at https://renku-ci-ui-2925.dev.renku.ch

…2890) Fix #2885

… users (#2891) (#2896) fix #2891 #2897

…)(#2912) (#2913) Fix #2911 #2912

…e landing page

andre-code · 2023-11-28T15:36:08Z

Lighthouse report:

SonarQube report (compared to master):

leafty

Simpler to understand pulse @keyframes:

client/src/styles/bootstrap_ext/_button.scss

client/src/components/AsyncImage/AsyncImage.tsx

client/src/landing/Graphics/hero_graph.svg

client/src/components/list/EntityCardSkeleton.module.scss

client/src/components/entities/Buttons.tsx

client/src/features/session/components/SimpleSessionButton.tsx

client/src/features/session/components/StartNewSession.tsx

client/src/landing/Dividier/Divider.tsx

client/src/styles/bootstrap_ext/_button.scss

leafty · 2023-11-29T12:33:52Z

client/src/landing/Graphics/computoOptions.svg

nitpick: rename file to session-classes.svg.

client/src/landing/WhatIsRenku/WhatIsRenku.tsx

…there is no project path or dataset slug, fix the styles prefix, and add a COPYRIGHT header

client/src/features/session/components/SimpleSessionButton.tsx

client/src/features/session/components/StartNewSession.tsx

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>

leafty

LGTM

There is one small issue still with the navbar menu:

I think you can update here

renku-ui/client/src/landing/anonymousHomeNav.tsx

Line 196 in f993a4c

style={{ "--rk-bg-opacity": 0.8 } as CSSProperties}

and add zIndex: 100.

RenkuBot · 2023-11-29T16:11:10Z

Tearing down the temporary RenkuLab deplyoment for this PR.

andre-code temporarily deployed to renku-ci-ui-2925 November 27, 2023 20:53 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2925 November 27, 2023 21:49 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2925 November 27, 2023 22:00 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2925 November 28, 2023 08:18 — with GitHub Actions Inactive

leafty self-requested a review November 28, 2023 09:03

andre-code added 3 commits November 28, 2023 15:39

feat(client): add hero section landing page anonymous users (#2885) (#…

8f1771b

…2890) Fix #2885

feat: add get started & Who is Behind sections landing page anonymous…

e8ae5f5

… users (#2891) (#2896) fix #2891 #2897

feat(client): Add Teaching & What Is Renku sections landing page (#2911…

cbdcf02

…)(#2912) (#2913) Fix #2911 #2912

andre-code force-pushed the 3357-redesign-landing-page branch from 25ec45b to cbdcf02 Compare November 28, 2023 14:42

andre-code had a problem deploying to renku-ci-ui-2925 November 28, 2023 14:43 — with GitHub Actions Failure

fix(client): Add project path and dataset slug home parameters for th…

3b01383

…e landing page

andre-code temporarily deployed to renku-ci-ui-2925 November 28, 2023 14:55 — with GitHub Actions Inactive

leafty reviewed Nov 28, 2023

View reviewed changes

client/src/styles/bootstrap_ext/_button.scss Outdated Show resolved Hide resolved

client/src/styles/bootstrap_ext/_button.scss Outdated Show resolved Hide resolved

client/src/styles/bootstrap_ext/_button.scss Outdated Show resolved Hide resolved

leafty reviewed Nov 28, 2023

View reviewed changes

client/src/styles/bootstrap_ext/_button.scss Outdated Show resolved Hide resolved

leafty reviewed Nov 28, 2023

View reviewed changes

client/src/components/AsyncImage/AsyncImage.tsx Outdated Show resolved Hide resolved

andre-code temporarily deployed to renku-ci-ui-2925 November 28, 2023 16:30 — with GitHub Actions Inactive

feat(client): update ssh connect images

1f1ae92

andre-code force-pushed the 3357-redesign-landing-page branch from 1e1a41a to 1f1ae92 Compare November 28, 2023 18:02

andre-code temporarily deployed to renku-ci-ui-2925 November 28, 2023 18:03 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2925 November 28, 2023 21:35 — with GitHub Actions Inactive

remove unused component, simplify pulse animation and fix button styles

863d20d

andre-code temporarily deployed to renku-ci-ui-2925 November 29, 2023 08:14 — with GitHub Actions Inactive

leafty reviewed Nov 29, 2023

View reviewed changes

client/src/landing/Graphics/hero_graph.svg Outdated Show resolved Hide resolved

leafty reviewed Nov 29, 2023

View reviewed changes

client/src/components/list/EntityCardSkeleton.module.scss Outdated Show resolved Hide resolved

andre-code had a problem deploying to renku-ci-ui-2925 November 29, 2023 10:12 — with GitHub Actions Error

change gif animation, skeleton animation and update dataset id

41a9ca5

andre-code force-pushed the 3357-redesign-landing-page branch from d4b74a6 to 41a9ca5 Compare November 29, 2023 10:14

andre-code had a problem deploying to renku-ci-ui-2925 November 29, 2023 10:14 — with GitHub Actions Error

andre-code temporarily deployed to renku-ci-ui-2925 November 29, 2023 10:22 — with GitHub Actions Inactive

andre-code temporarily deployed to renku-ci-ui-2925 November 29, 2023 10:37 — with GitHub Actions Inactive

andre-code marked this pull request as ready for review November 29, 2023 10:53

andre-code requested a review from a team as a code owner November 29, 2023 10:53

andre-code temporarily deployed to renku-ci-ui-2925 November 29, 2023 11:17 — with GitHub Actions Inactive

leafty requested changes Nov 29, 2023

View reviewed changes

leafty reviewed Nov 29, 2023

View reviewed changes

client/src/landing/Graphics/computoOptions.svg Outdated

Copy link

Member

leafty Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: rename file to session-classes.svg.

leafty requested changes Nov 29, 2023

View reviewed changes

client/src/landing/WhatIsRenku/WhatIsRenku.tsx Outdated Show resolved Hide resolved

Fix back URL when open link in another tab, don't show the button if …

ef8ad9c

…there is no project path or dataset slug, fix the styles prefix, and add a COPYRIGHT header

andre-code had a problem deploying to renku-ci-ui-2925 November 29, 2023 13:52 — with GitHub Actions Failure

andre-code requested a review from leafty November 29, 2023 13:54

andre-code temporarily deployed to renku-ci-ui-2925 November 29, 2023 14:11 — with GitHub Actions Inactive

leafty requested changes Nov 29, 2023

View reviewed changes

client/src/features/session/components/SimpleSessionButton.tsx Outdated Show resolved Hide resolved

client/src/features/session/components/StartNewSession.tsx Outdated Show resolved Hide resolved

client/src/features/session/components/StartNewSession.tsx Outdated Show resolved Hide resolved

andre-code and others added 3 commits November 29, 2023 15:35

Update client/src/features/session/components/SimpleSessionButton.tsx

330cac1

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>

Update client/src/features/session/components/StartNewSession.tsx

79f246e

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>

Update client/src/features/session/components/StartNewSession.tsx

56c7ca1

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>

andre-code had a problem deploying to renku-ci-ui-2925 November 29, 2023 14:35 — with GitHub Actions Error

andre-code temporarily deployed to renku-ci-ui-2925 November 29, 2023 14:38 — with GitHub Actions Inactive

andre-code requested a review from leafty November 29, 2023 14:45

leafty previously approved these changes Nov 29, 2023

View reviewed changes

format code and fix menu navigation

4e986b3

andre-code dismissed leafty’s stale review via 4e986b3 November 29, 2023 15:24

andre-code force-pushed the 3357-redesign-landing-page branch from f993a4c to 4e986b3 Compare November 29, 2023 15:24

andre-code deployed to renku-ci-ui-2925 November 29, 2023 15:24 — with GitHub Actions View deployment

leafty approved these changes Nov 29, 2023

View reviewed changes

andre-code merged commit f3d5870 into master Nov 29, 2023
17 checks passed

andre-code deleted the 3357-redesign-landing-page branch November 29, 2023 16:10

andre-code mentioned this pull request Nov 29, 2023

build: release 3.17.0 #2929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(client): redesign landing page #2925

feat(client): redesign landing page #2925

andre-code commented Nov 27, 2023

RenkuBot commented Nov 27, 2023

andre-code commented Nov 28, 2023 •

edited

leafty left a comment

leafty Nov 29, 2023

leafty left a comment

RenkuBot commented Nov 29, 2023

feat(client): redesign landing page #2925

feat(client): redesign landing page #2925

Conversation

andre-code commented Nov 27, 2023

RenkuBot commented Nov 27, 2023

andre-code commented Nov 28, 2023 • edited

leafty left a comment

Choose a reason for hiding this comment

leafty Nov 29, 2023

Choose a reason for hiding this comment

leafty left a comment

Choose a reason for hiding this comment

RenkuBot commented Nov 29, 2023

andre-code commented Nov 28, 2023 •

edited