Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align font size and text color with rest of the home page #2968

Merged
merged 3 commits into from Jan 17, 2024

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 15, 2024

Match the font size and color in the showcase section with the rest of the homepage.

Large viewport
image

image

Small viewport
image

image

Fix #2963

/deploy extra-values=ui.homepage.showcase.enabled=true,ui.homepage.showcase.title=Renku,ui.homepage.showcase.description=Description,ui.homepage.showcase.projects[0].identifier=hdbi/data-management/cccooci

@ciyer ciyer requested a review from a team as a code owner January 15, 2024 10:32
@ciyer ciyer force-pushed the ciyer/2963-landing-page-font-size branch from a26ba97 to c099ee1 Compare January 15, 2024 10:33
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2968.dev.renku.ch

@@ -31,3 +35,51 @@
--swiper-navigation-sides-offset: 0px;
--swiper-theme-color: #01192d;
}

#sectionShowcaseHeader {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use a classname here? the style will not spill out anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made this change (see a43b30b).

@ciyer ciyer force-pushed the ciyer/2963-landing-page-font-size branch from a43b30b to 44b163b Compare January 16, 2024 11:29
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciyer ciyer merged commit f9d9858 into master Jan 17, 2024
14 of 17 checks passed
@ciyer ciyer deleted the ciyer/2963-landing-page-font-size branch January 17, 2024 08:49
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font adjustments - Landing page, section "Renku real-world use cases"
3 participants