Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): hide button to add storage when the feature is turned off #3001

Merged
merged 1 commit into from Jan 26, 2024

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Jan 25, 2024

We should not show the button to add a new storage service in deployments that do not support it

image

/deploy renku=000-cypress-storage-off

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3001.dev.renku.ch

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzo-cavazzi lorenzo-cavazzi merged commit f47bdd4 into master Jan 26, 2024
22 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the 000-fix-add-storage branch January 26, 2024 08:19
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants