Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): handle jsonrpc improper redirects #3017

Merged
merged 4 commits into from Feb 8, 2024
Merged

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 6, 2024

Fixes #2966.

How to reproduce the original issue:

  1. Start a session
  2. Once the session is starting immediately go back
    Screenshot 2024-02-06 at 14 42 59
  3. On the sessions view, try to delete the session

/deploy

@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 6, 2024

You can access the deployment of this PR at https://renku-ci-ui-3017.dev.renku.ch

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to provoke the original bug that this fixes, so I cannot verify that the problem existed before and has been fixed by these changes, but the code changes make sense.

@leafty leafty merged commit 3d221e1 into main Feb 8, 2024
16 of 17 checks passed
@leafty leafty deleted the leafty/2966-fix-jsonrpc branch February 8, 2024 13:08
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 8, 2024

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to delete a session sometimes crashes the UI
3 participants