chore: R & RStudio to latest rocker with CRAN snapshot #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @RichardJActon sorry I missed this PR - I think we should combine it with #396? If it makes sense to you I'll take your commit over to the other PR so the CI will run. |
rokroskar
reviewed
Oct 20, 2023
| @@ -1,6 +1,6 @@ | |||
| # define build arguments | |||
| ARG RENKU_BASE=renku/renkulab-py:latest | |||
| ARG BASE_IMAGE=rocker/verse:devel | |||
| ARG BASE_IMAGE=rocker/verse:4.3.0 | |||
There was a problem hiding this comment.
this probably isn't needed since it's overridden in the CI anyway
|
Hi @RichardJActon I've taken your commit over to #396 - will close this now and continue over there. Thanks again for making the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RStudio, R & Quarto versions in the default R 4.2.0 image are getting a little old now, especially the quarto version which is moving quite fast.
I tested a project based on an image built with these changes using the default R project template and it seems to work perfectly fine.
rocker/verse:devel gives R version 4.4.0 which is still the development version rather than the latest stable release so I switched it to 4.3.0 for verse and 2023.06.0-421 based on the latest versions from rocker https://github.com/rocker-org/rocker-versioned2/wiki/Versions for which there is a CRAN snapshot. That way other R package installs should have fixed versions based on that CRAN snapshot by default.