Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use powerline for terminal prompt #75

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Feb 28, 2020

Prettifies the terminal shell with powerline.

screenshot:

image

closes #31

emmjab
emmjab previously approved these changes Mar 2, 2020
Copy link
Contributor

@emmjab emmjab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome! tested here: https://dev.renku.ch/projects/e.jablonski/base-docker-image-tests at commit 4e3194ce.

The coloring & characters for commits might help solve the open issue about helping users realize they need to push more often.

@rokroskar
Copy link
Member Author

Thanks for testing @emmjab - btw, do you have powerline fonts installed on your computer already?

@rokroskar
Copy link
Member Author

I resorted to using the "compatible" mode that results in an uglier font but the alternative is requiring that the user installs fonts on their system, which I think is a no-go.

@rokroskar
Copy link
Member Author

I just changed all the image builds to use compatible mode and to not install any fonts. Please re-approve.

@rokroskar rokroskar requested a review from emmjab March 2, 2020 11:50
@emmjab
Copy link
Contributor

emmjab commented Mar 3, 2020

Thanks for testing @emmjab - btw, do you have powerline fonts installed on your computer already?

Nope!

I just changed all the image builds to use compatible mode and to not install any fonts. Please re-approve.

Re-testing now.

Also I agree it would be nice to have a common/ dir for dependencies that all the images share, in a following PR; so long as we make it clear what's going on in the docker file.

Copy link
Contributor

@emmjab emmjab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify command line
2 participants