-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix volume mapping #107
Fix volume mapping #107
Conversation
@Carael could you possibly trigger CI? would be good to unblock this |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
var content = await response.Content.ReadAsStringAsync(); | ||
|
||
//Assert | ||
content.Should().Contain("Hello Squadron unit test!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could actually make a snapshot here with Snapshooter but it's only a suggestion. It's ok so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for your contribution!
Kudos, SonarCloud Quality Gate passed!
|
HostConfig.Bind
property.Adding volume mappings to
CreateContainerParameters.Volumes
doesn't seem to work as expected in Docker.Dotnet - the fix is to use theBinds
property when creating aHostConfig
. The issue is tracked here dotnet/Docker.DotNet#226