Added support for Azure Event Hub #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
glucaci
requested changes
Jun 30, 2021
| <AssemblyName>Squadron.AzureCloudEventHub.Tests</AssemblyName> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> |
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
|
|
||
| namespace Squadron.AzureCloudEventHub.Tests | ||
| { | ||
| public class AzureNewEventHubResourceTests |
There was a problem hiding this comment.
Add test also for existing eventhub
There was a problem hiding this comment.
A test has been added in class AzureExistingEventHubResourceTests
| <ProjectReference Include="..\Core\Core.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
|
|
| private EventHubOptionsBuilder() | ||
| : base() | ||
| { | ||
|
|
| /// <returns></returns> | ||
| public static EventHubOptionsBuilder New() => new EventHubOptionsBuilder(); | ||
|
|
||
|
|
- add test for existing event hub namespace - remove blank lines and empty itemgroup
glucaci
requested changes
Jul 2, 2021
| "SubscriptionId": "", | ||
| "ResourceGroup": "", | ||
| "DefaultLocation": "", | ||
| "SubscriptionId": "3764e1f0-3a1b-4a28-a340-1ed0d8d388fd", |
There was a problem hiding this comment.
thanks - must have gone too fast wehen I committed. All secrets are removed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@glucaci it seems like RabbitMQ and ReavenDB tests are failing, which are tests that shouldn't be affected by this PR |
|
Kudos, SonarCloud Quality Gate passed!
|
glucaci
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support in Squadron for Azure Event Hubs. It is possible to create an EventHub namespace with one or more EventHubs in it. Test shows how to publish and consume events on a new event hub and assert that the message published is similar to what this consumed.