New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blinking cursor support #540
Add blinking cursor support #540
Conversation
Hi @kklemon . This looks very good, thank you. The problem I see with blinking cursor is that it might be a bit heavy on resources (since it's a whole terminal repaint at every second), could you please set it by default to false and update the default profiles to have it disabled (this should avoid breaking backward compatibility)? |
That's a valid point but the cursor does only blink if the window is focused and in this case, the user is probably typing anyway which also casts redraws. Also, the 500 ms default blink interval is much longer than the ones of most other effects. But disabling it by default for backward compatibility is a good point. |
Thank you very much and sorry for the very long delay with this pull request. |
Is there support for blinking cursor now? And if so, how do I enable it? 😄 EDIT 1: I can see that there was added support for it on May 29 2020, but that there is no release for at, so will you release v1.1.2? EDIT 2: Just tried to build , but get the following error:
|
I haven't been involved with the project for quite some time, but indeed the feature is merged into master but with no release yet. If you want to build it manually, you have to build and install https://github.com/Swordfish90/qmltermwidget from master as well, as the functionality is essentially implemented there. |
I get the same. I have built that qmltermwidget and generated the libqmltermwidget.so. but where I need to place it so it can work? Thanks. |
I answer my self. It goes in /usr/lib/qt/qml/QMLTermWidget/libqmltermwidget.so |
Adds support for blinking cursor.
The
qmltermwidget
submodule is updated to expose a corresponding property (see Swordfish90/qmltermwidget#25).The blinking cursor option is enabled by default and can be tweaked in the terminal settings tab.