Make client module lazy #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you remove the version bump and add this to the changelog I can merge it. Thanks for making the PR! |
|
Ok, no problem! I'll find some time soon! |
|
Thanks again @moberegger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply makes the meteor package's client module lazy. This just prevents the module from being included in the app bundle until it is
imported. This is particularly useful if the developer opts to use this atmosphere package with theapollo-link-ddpnpm module instead; without thelazyoption, the client will get bundled with app no matter what.Note that this includes a bump to
2.2.0. This is because my other PR (#276) bumps to2.1.0.