Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian translation #2809

Merged
merged 11 commits into from
Aug 16, 2023
Merged

Add Ukrainian translation #2809

merged 11 commits into from
Aug 16, 2023

Conversation

dmytrovoytko
Copy link
Contributor

Hi! Thank you for this project!
I'd like to contribute by adding Ukrainian translation, please consider my PR.

@CandidDeer
Copy link
Collaborator

@Syknapse Please review this PR for feasibility to merge. Thx.

@TenTraicion
Copy link
Collaborator

@dmytrovoytko, @CandidDeer i think the links need to be checked properly.

@dmytrovoytko
Copy link
Contributor Author

the links need to be checked properly
@TenTraicion Agree! I checked several times and be glad to correct if something is missed, any particular issues?

@TenTraicion
Copy link
Collaborator

@dmytrovoytko, it's a great addition to our project and thanks a bunch for that. There are some link issues, like in the translation table, the links are broken. you may check the reference on other translations of our project.

That's why i asked to check the links properly, cause there might be other issues in there as they are all dynamic. Thanks.

Copy link
Owner

@Syknapse Syknapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you for the contribution, it's very helpful to add a new translation 💪🏼🇺🇦
From my part once any issues have been resolved it's good to merge

@dmytrovoytko
Copy link
Contributor Author

@TenTraicion > translation table
I really missed those relative links, thank you.
Fixed! And I checked the rest of relative links, looks ok.

Copy link
Collaborator

@TenTraicion TenTraicion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TenTraicion TenTraicion merged commit 89d011a into Syknapse:master Aug 16, 2023
1 check passed
@TenTraicion
Copy link
Collaborator

@dmytrovoytko, Congratulation on your PR Merge, and Thanks for your Contribution. You can check your card in our Live Website! It may take 2-3 minutes to make your card visible in our website.

Welcome to Open Source Community. You can follow the Next Steps now. You are also welcome to join our Discord Server: https://discord.gg/tWkvS4ueVF and be a part of our community.

@dmytrovoytko
Copy link
Contributor Author

@CandidDeer @TenTraicion @Syknapse Thank you all! 💛💙

@Syknapse
Copy link
Owner

@CandidDeer @TenTraicion @Syknapse Thank you all! 💛💙

All thanks to you for contributing to our project and making it more useful for more people.

@TenTraicion TenTraicion linked an issue Aug 31, 2023 that may be closed by this pull request
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations for main README
4 participants