Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traditional Chinese README.md #2873

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

ascodeasice
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@TenTraicion TenTraicion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascodeasice, looks fine to me. But i will recommend some changes:

  1. Input in the language table alphabetically. (Optional)

Thanks for all the hard work. and we are looking forward to more contributions of your.

-Regards

Sort by alphabetical order, use chinese (traditional) for easier sorting
@ascodeasice
Copy link
Collaborator Author

Hi, I used Chinese (Traditional) in table since there's sorting

Copy link
Collaborator

@TenTraicion TenTraicion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascodeasice, need some more changes, mentioned below:

README.md Outdated Show resolved Hide resolved
translations/translation.md Outdated Show resolved Hide resolved
translations/translation.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TenTraicion TenTraicion added the changes requested Contributor is requested to make the required changes label Aug 30, 2023
@ascodeasice
Copy link
Collaborator Author

Done, thanks for reminding!

@TenTraicion TenTraicion merged commit 596b9e1 into Syknapse:master Aug 31, 2023
1 check failed
@TenTraicion
Copy link
Collaborator

@ascodeasice, Congratulation on your PR Merge, and Thanks for your Contribution. Don't forget to add your card in our project. Looking forward to your future contributions.

Welcome to Open Source Community. You can follow the Next Steps now. You are also welcome to join our Discord Server: https://discord.gg/tWkvS4ueVF and be a part of our community.

@TenTraicion TenTraicion linked an issue Aug 31, 2023 that may be closed by this pull request
21 tasks
@TenTraicion TenTraicion added enhancement translation and removed changes requested Contributor is requested to make the required changes labels Aug 31, 2023
@ascodeasice ascodeasice deleted the traditional-chinese-readme branch December 26, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations for main README
2 participants