[LineItem] Revert changing return type of invoice

Sylius · Sep 16, 2021 · ca9d93e · ca9d93e
1 parent 95e2a09
commit ca9d93e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,8 +1,3 @@
-### UPGRADE FROM 0.18.0 TO 0.19.0
-
-1. The return type of `Sylius\InvoicingPlugin\Entity\LineItemInterface:invoice` method has been changed
-   from `InvoiceInterface` to `?InvoiceInterface`
-
 ### UPGRADE FROM 0.17.0 TO 0.18.0
 
 1. The `Sylius\InvoicingPlugin\Converter\BillingDataConverter` has been removed in favor of `Sylius\InvoicingPlugin\Factory\BillingDataFactory->createFromAddress`.

diff --git a/src/Entity/LineItem.php b/src/Entity/LineItem.php
@@ -22,7 +22,7 @@ class LineItem implements LineItemInterface, ResourceInterface
     /** @var mixed */
     protected $id;
 
-    protected ?InvoiceInterface $invoice = null;
+    protected InvoiceInterface $invoice;
 
     protected string $name;
 
@@ -74,7 +74,7 @@ public function id()
         return $this->id;
     }
 
-    public function invoice(): ?InvoiceInterface
+    public function invoice(): InvoiceInterface
     {
         return $this->invoice;
     }

diff --git a/src/Entity/LineItemInterface.php b/src/Entity/LineItemInterface.php
@@ -17,7 +17,7 @@ interface LineItemInterface
 {
     public function id();
 
-    public function invoice(): ?InvoiceInterface;
+    public function invoice(): InvoiceInterface;
 
     public function setInvoice(InvoiceInterface $invoice): void;