Make all plugin templates possible to overwrite #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszpietrzak1994
approved these changes
Mar 13, 2019
|
Thanks, Mateusz! 🎉 |
GSadee
added a commit
to Sylius/AdminOrderCreationPlugin
that referenced
this pull request
Nov 22, 2019
…123) This PR was merged into the 1.1-dev branch. Discussion ---------- The same changes as in Sylius/InvoicingPlugin#116 Commits ------- 9e1bbe1 Allow to overwrite order created email template 8e85f31 Conflict symfony/cache:^5.0 due to class removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
Ok, I think we've finally managed (kinda) to resolve this problem 😄 There are some problems in Sylius (or even in Symfony itself) with overwriting templates, that are not configured with a one, specific path style. It should always follow
@SyliusTestPlugin/Catalog/templateName.html.twigconvention - and as you can see, there were some other conventions used :) It would be good if someone could test these changes before merging (cc @itwhy), but I've tested all plugin templates on a fresh Sylius-Standard application and it worked 🚀