Single page payment #150
Single page payment #150
Conversation
SirDomin
force-pushed
the
single-page-payment
branch
2 times, most recently
from
cc82d09
to
c72e6d7
Compare
src/Resources/views/bundles/SyliusShopBundle/Checkout/complete.html.twig
Outdated
Show resolved
Hide resolved
| /** @var PaymentMethodInterface $paymentMethod */ | ||
| $paymentMethod = $payment->getMethod(); | ||
| /** @var GatewayConfigInterface $gatewayConfig */ | ||
| $gatewayConfig = $paymentMethod->getGatewayConfig(); |
There was a problem hiding this comment.
There are so many places where we get data from the gateway config :/ We should definitely extract some service for that (but, of course, not in this PR 🖖)
There was a problem hiding this comment.
We need some more tests on that :/
-
after successful payment, there is another, cart payment in the fulfilled order
-
when you try to pay by PayPal or hosted payment method (like Przelewy24) and cancel it, it returns to complete page with processing payment - and after clicking "Place order" there is a
"Unable to generate a URL for the named route "sylius_paypal_plugin_pay_with_paypal_form" as such route does not exist.exception.
SirDomin
force-pushed
the
single-page-payment
branch
from
5497178
to
cddc64c
Compare
|
I've pushed some visual changes, which I think would be more consistent with the default "Place order" UI:
|
|
It would be nice to fix it. I would also like to merge it after the 1.0.0 release, as it's the improvement/change of the currently working feature, that could quite possibly change a lot :) |
Zales0123
force-pushed
the
single-page-payment
branch
from
4b199c3
to
3d8b66c
Compare
Zales0123
force-pushed
the
single-page-payment
branch
from
e91f27e
to
956e1ce
Compare
| @@ -135,4 +150,39 @@ public function renderPaymentPageButtonsAction(Request $request): Response | |||
| return new Response(''); | |||
| } | |||
| } | |||
|
|
|||
| public function renderPayPalPaymentAction(Request $request): Response | |||
There was a problem hiding this comment.
I'm not a huge fan of the "no verification at all" to who is the owner of the order. Changing the orderId in the request could lead to some issues here. Is it right?
Zales0123
force-pushed
the
single-page-payment
branch
from
a61c84c
to
6f72e02
Compare
instead of default sylius button we get paypal form to finish our payment
fixes #116