fix window reload on javascript payment callbacks #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometee
requested changes
Sep 23, 2023
| @@ -268,7 +268,7 @@ | |||
| method: 'post', | |||
| headers: {}, | |||
| body: error | |||
| }).then(window.location.reload()); | |||
| }).then(() => window.location.reload()); | |||
There was a problem hiding this comment.
Suggested change
| }).then(() => window.location.reload()); | |
| }).then(window.location.reload); |
window.location.reload is a function
window.location.reload() is the function call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there was an issue with the javascripts in the payWithPaypal template.
The
window.location.reload()in error and cancel callbacks was executed instead of being passed as a callback in thefetch().then()function.The page was reloading before the call was made and the payment was never cancelled, so the payment could not be processed again !
Had to override locally because half of our paypal orders fell in that and payment were never completed.