Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Bring back var folder #11

Merged
merged 1 commit into from
Mar 9, 2017
Merged

[Maintenance] Bring back var folder #11

merged 1 commit into from
Mar 9, 2017

Conversation

lchrusciel
Copy link
Member

No description provided.

@pjedrzejewski pjedrzejewski requested a review from pamil March 9, 2017 12:12
pamil
pamil reviewed Mar 9, 2017
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about using sys_get_temp_dir() to host these files, so we won't have them generated inside our project. This would require a change in AppKernel, but the whole var directory won't be needed then.

See https://github.com/pamil/Sylius/blob/5cb391797f3307f42f2db692e0fb663a747489a9/src/Sylius/Bundle/TaxonomyBundle/Tests/Functional/app/AppKernel.php#L47-L61 - wdyt?

@lchrusciel
Copy link
Member Author

lchrusciel commented Mar 9, 2017 •
edited

Seems legit for me, as it is needed only for tests purposes. I will keep it open until we will fix this.

@pamil pamil merged commit b8e9847 into Sylius:master Mar 9, 2017
@pamil
Copy link
Contributor

pamil commented Mar 9, 2017

Hmm, let's merge this and switch to the temporary dir in next iteration 🎉

@lchrusciel lchrusciel mentioned this pull request Mar 9, 2017
Closed
@lchrusciel lchrusciel deleted the var branch September 18, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lchrusciel @pamil