Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Add scenarios for disabling showing the lowest price before the current discount #14

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Feb 3, 2023

No description provided.

@coldic3 coldic3 added the Behat Issues and PRs aimed at improving Behat usage. label Feb 3, 2023
Copy link
Contributor

@NoResponseMate NoResponseMate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update scenarios are missing

@coldic3 coldic3 force-pushed the feature/toggle-for-the-lowest-price-before-current-discount-behat branch from bfcc9d7 to 906f274 Compare February 6, 2023 10:54
@coldic3 coldic3 force-pushed the feature/toggle-for-the-lowest-price-before-current-discount-behat branch from 906f274 to 026f32b Compare February 6, 2023 11:08
@coldic3 coldic3 force-pushed the feature/toggle-for-the-lowest-price-before-current-discount-behat branch from 026f32b to 22cafb5 Compare February 8, 2023 11:59
And I am logged in as an administrator

@todo
Scenario: Adding a new channel with lowest price from 30 days before the product has been discounted enabled by default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that you would remove 30 days everywhere in your scenarios 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I didn't know I have it in scenarios also – will fix that later 👍

@GSadee GSadee merged commit abb88ec into Sylius:main Feb 8, 2023
@GSadee
Copy link
Member

GSadee commented Feb 8, 2023

Thank you, Kevin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants