[Maintenance] Fix composer autoload #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
approved these changes
Feb 6, 2023
Rafikooo
approved these changes
Feb 6, 2023
|
Thank you, @NoResponseMate! |
GSadee
reviewed
Feb 6, 2023
| } | ||
| }, | ||
| "autoload-dev": { | ||
| "psr-4": { | ||
| "spec\\Sylius\\PriceHistoryPlugin\\": "spec/", | ||
| "Tests\\Sylius\\PriceHistoryPlugin\\": "tests/", |
There was a problem hiding this comment.
If I'm thinking correctly, moving tests to dev autoload will mean that you won't be able to use our behat services (contexts etc) in the end application, so although this configuration makes sense and seems more correct, I don't know if it's recommended for our products
GSadee
added a commit
that referenced
this pull request
Feb 10, 2023
…ate) This PR was merged into the main branch. Discussion ---------- Investigated a bit as per [the comment](#15 (comment)) and it indeed seems to be the case. Commits ------- 4a77eab [Maintenance] Expose behat classes in autoload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.