Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

[Access] Refactor OperationType model #28

Merged
merged 2 commits into from
Nov 28, 2018
Merged

[Access] Refactor OperationType model #28

merged 2 commits into from
Nov 28, 2018

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 28, 2018

No description provided.

@bartoszpietrzak1994
Copy link
Contributor

Why do you want to get rid of the flyweight pattern here? :D

@GSadee
Copy link
Member Author

GSadee commented Nov 28, 2018

@bartoszpietrzak1994 where is the flyweight pattern in this example? It looks more like overengineering IMO :D

And it causes:
image

@bartoszpietrzak1994
Copy link
Contributor

Yeah, when i looked at screenshot you've placed above I realised where the mistake was. :( It's ok, to be merged :)

@bartoszpietrzak1994 bartoszpietrzak1994 merged commit cea291f into Sylius:master Nov 28, 2018
@GSadee GSadee deleted the operation-type-refactor branch November 28, 2018 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants