Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Composer] Remove composer.lock from .gitignore after creating the project #855

Merged
merged 2 commits into from
Jan 17, 2023
Merged

[Composer] Remove composer.lock from .gitignore after creating the project #855

merged 2 commits into from
Jan 17, 2023

Conversation

artyuum
Copy link
Contributor

@artyuum artyuum commented Oct 21, 2022

This fixes the issue #665.

Inspired by sulu/skeleton.

Can you review this, please? @lchrusciel

@artyuum artyuum requested a review from a team as a code owner October 21, 2022 06:45
Copy link
Contributor

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems interesting 🤔. There were plenty of discussions about composer.lock, but I'm for it 👍🏼.

@jakubtobiasz jakubtobiasz merged commit f278821 into Sylius:1.12 Jan 17, 2023
@jakubtobiasz
Copy link
Contributor

Thanks, Artyum! 🥇

@artyuum artyuum deleted the remove-composer-lock-from-gitignore branch January 18, 2023 14:49
frozenpixel added a commit to frozenpixel/Sylius-Celletech that referenced this pull request Jul 7, 2023
v1.12.3

- [Sylius#873](Sylius#873) [maintenance] - Ignore yarn.lock file ([@Ferror](https://github.com/Ferror))
- [Sylius#861](Sylius#861) [docker] - Bug fix for cron container ([@Ferror](https://github.com/Ferror))
- [Sylius#860](Sylius#860) [docker] - Enable cron container to wait for migrations ([@Ferror](https://github.com/Ferror))
- [Sylius#871](Sylius#871) Use @sylius-ui/frontend npm package ([@jakubtobiasz](https://github.com/jakubtobiasz))
- [Sylius#891](Sylius#891) [Maintenance] PHP Attributes in the Entity classes ([@Rafikooo](https://github.com/Rafikooo))
- [Sylius#855](Sylius#855) [Composer] Remove composer.lock from .gitignore after creating the project ([@artyuum](https://github.com/artyuum))
- [Sylius#899](Sylius#899) Fix builds ([@coldic3](https://github.com/coldic3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants