[maintenance] - Ignore yarn.lock file #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably think about automatically removing it from .gitignore when a new project is created. |
vvasiloi
approved these changes
Nov 15, 2022
coldic3
approved these changes
Nov 21, 2022
| @@ -93,7 +93,7 @@ RUN set -eux; \ | |||
| ; | |||
|
|
|||
| # prevent the reinstallation of vendors at every changes in the source code | |||
| COPY package.json yarn.lock ./ | |||
| COPY package.json yarn.* ./ | |||
There was a problem hiding this comment.
Suggested change
| COPY package.json yarn.* ./ | |
| COPY package.json yar[n].lock ./ |
is a safer option to avoid having errors for a non-existent file but it looks strange 😄
frozenpixel
added a commit
to frozenpixel/Sylius-Celletech
that referenced
this pull request
Jul 7, 2023
v1.12.3 - [Sylius#873](Sylius#873) [maintenance] - Ignore yarn.lock file ([@Ferror](https://github.com/Ferror)) - [Sylius#861](Sylius#861) [docker] - Bug fix for cron container ([@Ferror](https://github.com/Ferror)) - [Sylius#860](Sylius#860) [docker] - Enable cron container to wait for migrations ([@Ferror](https://github.com/Ferror)) - [Sylius#871](Sylius#871) Use @sylius-ui/frontend npm package ([@jakubtobiasz](https://github.com/jakubtobiasz)) - [Sylius#891](Sylius#891) [Maintenance] PHP Attributes in the Entity classes ([@Rafikooo](https://github.com/Rafikooo)) - [Sylius#855](Sylius#855) [Composer] Remove composer.lock from .gitignore after creating the project ([@artyuum](https://github.com/artyuum)) - [Sylius#899](Sylius#899) Fix builds ([@coldic3](https://github.com/coldic3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Related with #872