Prevents click jacking #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love this. But this is not good for everyone. There is for example dedicated product review page and this can be embedded for some advertisements or landing pages. This will prevent that. |
|
I know @FDiskas , but i think Sylius should (i don't know if they always already do that) follow the security by default approach. |
lchrusciel
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Hey Luca,
your opinion + OWASP recommendation are more than enough for me to be for merging of this PR (ref. https://cheatsheetseries.owasp.org/cheatsheets/Clickjacking_Defense_Cheat_Sheet.html)
Zales0123
approved these changes
Feb 24, 2021
pamil
approved these changes
Mar 23, 2021
|
Thanks, Luca! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, there is no protection against click-jacking. Given the nature of the platform (credentials, credit cards informations ecc) i think that this should be the default behavior.
What do you think?
Doc reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options