[API][Orders] Validate item quantity change

Sylius · Jul 3, 2023 · 200ea9e · 200ea9e
1 parent 0ab079e
commit 200ea9e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/UPGRADE-API-1.13.md b/UPGRADE-API-1.13.md
@@ -1,6 +1,6 @@
 # UPGRADE FROM `v1.12.x` TO `v1.13.0`
 
-1. The signature of constructor and `createFromData` method of 'Sylius\Bundle\ApiBundle\Command\Cart\ChangeItemQuantityCart' command changed:
+1. The signature of constructor of 'Sylius\Bundle\ApiBundle\Command\Cart\ChangeItemQuantityInCart' command changed:
 
 ````diff
     public function __construct(
@@ -10,15 +10,6 @@
     } 
 ````
 
-````diff
-    public static function createFromData(
-        string $tokenValue, 
-        string $orderItemId, 
--       int $quantity,
-+       ?int $quantity,
-    ): self
-````
-
 1. The constructor signature of 'Sylius\Bundle\ApiBundle\Command\Cart\AddItemToCart' changed:
 
 ````diff

diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ChangeItemQuantityInCart.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ChangeItemQuantityInCart.xml
@@ -24,6 +24,10 @@
                 <option name="minMessage">sylius.order_item.quantity.min</option>
                 <option name="groups">sylius</option>
             </constraint>
+            <constraint name="NotBlank">
+                <option name="message">sylius.order_item.quantity.not_blank</option>
+                <option name="groups">sylius</option>
+            </constraint>
         </property>
     </class>
 </constraint-mapping>
diff --git a/src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChangedItemQuantityInCartValidator.php b/src/Sylius/Bundle/ApiBundle/Validator/Constraints/ChangedItemQuantityInCartValidator.php
@@ -40,6 +40,10 @@ public function validate($value, Constraint $constraint)
         /** @var ChangedItemQuantityInCart $constraint */
         Assert::isInstanceOf($constraint, ChangedItemQuantityInCart::class);
 
+        if ($value->quantity === null) {
+            return;
+        }
+
         /** @var OrderItemInterface|null $orderItem */
         $orderItem = $this->orderItemRepository->findOneBy(['id' => $value->orderItemId]);
         Assert::notNull($orderItem);

diff --git a/...us/Bundle/ApiBundle/spec/Validator/Constraints/ChangedItemQuantityInCartValidatorSpec.php b/...us/Bundle/ApiBundle/spec/Validator/Constraints/ChangedItemQuantityInCartValidatorSpec.php
@@ -14,6 +14,7 @@
 namespace spec\Sylius\Bundle\ApiBundle\Validator\Constraints;
 
 use PhpSpec\ObjectBehavior;
+use Prophecy\Argument;
 use Sylius\Bundle\ApiBundle\Command\Cart\ChangeItemQuantityInCart;
 use Sylius\Bundle\ApiBundle\Command\Checkout\CompleteOrder;
 use Sylius\Bundle\ApiBundle\Validator\Constraints\AddingEligibleProductVariantToCart;