[Behat][API] Minor improvements in managing variants contexts

Sylius · Dec 15, 2023 · 21cd6b6 · 21cd6b6
1 parent 4986106
commit 21cd6b6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/Sylius/Behat/Context/Api/Admin/BrowsingProductVariantsContext.php b/src/Sylius/Behat/Context/Api/Admin/BrowsingProductVariantsContext.php
@@ -67,15 +67,7 @@ public function theFirstVariantInTheListShouldHaveName(string $variantName): voi
 
         $firstVariant = reset($variants);
 
-        Assert::same(
-            $firstVariant['translations']['en_US']['name'],
-            $variantName,
-            sprintf(
-                'Expected first variant to have name "%s", but it is named "%s".',
-                $variantName,
-                $firstVariant['translations']['en_US']['name'],
-            ),
-        );
+        $this->assertProductVariantName($firstVariant['translations']['en_US']['name'], $variantName);
     }
 
     /**
@@ -87,13 +79,18 @@ public function theLastVariantInTheListShouldHaveName(string $variantName): void
 
         $lastVariant = end($variants);
 
+        $this->assertProductVariantName($lastVariant['translations']['en_US']['name'], $variantName);
+    }
+
+    private function assertProductVariantName(string $variantName, string $expectedVariantName): void
+    {
         Assert::same(
-            $lastVariant['translations']['en_US']['name'],
             $variantName,
+            $expectedVariantName,
             sprintf(
-                'Expected last variant to have name "%s", but it is named "%s".',
+                'Expected product variant to have name "%s", but it is named "%s".',
+                $expectedVariantName,
                 $variantName,
-                $lastVariant['translations']['en_US']['name'],
             ),
         );
     }

diff --git a/src/Sylius/Behat/Context/Api/Admin/ManagingProductReviewsContext.php b/src/Sylius/Behat/Context/Api/Admin/ManagingProductReviewsContext.php
@@ -210,7 +210,7 @@ public function iShouldBeNotifiedThatItHasBeenSuccessfullyDeleted(): void
     }
 
     /**
-     * @Then average rating of product :product should be :rating
+     * @Then average rating of product :product should be :expectedRating
      */
     public function averageRatingOfProductShouldBe(ProductInterface $product, int $expectedRating): void
     {