Refactor Product serialization groups

Sylius · Dec 30, 2020 · 300c8a1 · 300c8a1
1 parent ce35ba3
commit 300c8a1
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 35 deletions.
diff --git a/UPGRADE-1.8.md b/UPGRADE-1.8.md
@@ -28,6 +28,9 @@ If you are using they on your custom entity `api_resource` configuration or seri
     `order:create` changed to: `shop:order:create`
     `order:read` changed to: `admin:order:read`
     `order:update` changed to: `admin:order:update`
+    `product:create` changed to: `admin:product:create`
+    `product:read` changed to: `admin:product:read` and `shop:product:read`
+    `product:update` changed to: `admin:product:update`
     `shop:currencies:read` changed to: `shop:currency:read`
     `shop:customer:write` changed to: `shop:customer:create`
 

diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Product.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Product.xml
@@ -18,7 +18,7 @@
     <resource class="%sylius.model.product.class%" shortName="Product">
         <attribute name="normalization_context">
             <attribute name="groups">
-                <attribute>product:read</attribute>
+                <attribute>admin:product:read</attribute>
             </attribute>
         </attribute>
 
@@ -47,13 +47,16 @@
                     <attribute>sylius.api.product_taxon_code_filter</attribute>
                     <attribute>sylius.api.translation_order_name_and_locale_filter</attribute>
                 </attribute>
+                <attribute name="normalization_context">
+                    <attribute name="groups">shop:product:read</attribute>
+                </attribute>
             </collectionOperation>
 
             <collectionOperation name="admin_post">
                 <attribute name="method">POST</attribute>
                 <attribute name="path">/admin/products</attribute>
                 <attribute name="denormalization_context">
-                    <attribute name="groups">product:create</attribute>
+                    <attribute name="groups">admin:product:create</attribute>
                 </attribute>
             </collectionOperation>
         </collectionOperations>
@@ -73,13 +76,16 @@
                 <attribute name="openapi_context">
                     <attribute name="summary">Use code to retrieve a product resource.</attribute>
                 </attribute>
+                <attribute name="normalization_context">
+                    <attribute name="groups">shop:product:read</attribute>
+                </attribute>
             </itemOperation>
 
             <itemOperation name="admin_put">
                 <attribute name="method">PUT</attribute>
                 <attribute name="path">/admin/products/{id}</attribute>
                 <attribute name="denormalization_context">
-                    <attribute name="groups">product:update</attribute>
+                    <attribute name="groups">admin:product:update</attribute>
                 </attribute>
             </itemOperation>
 

diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Product.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Product.xml
@@ -17,48 +17,59 @@
 >
     <class name="Sylius\Component\Core\Model\Product">
         <attribute name="id">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="code">
-            <group>product:read</group>
-            <group>product:create</group>
+            <group>admin:product:create</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="createdAt">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="updatedAt">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="translations">
-            <group>product:read</group>
-            <group>product:create</group>
-            <group>product:update</group>
+            <group>admin:product:create</group>
+            <group>admin:product:read</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="mainTaxon">
-            <group>product:read</group>
-            <group>product:create</group>
-            <group>product:update</group>
+            <group>admin:product:create</group>
+            <group>admin:product:read</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="productTaxons">
-            <group>product:read</group>
-            <group>product:update</group>
-            <group>product:create</group>
+            <group>admin:product:create</group>
+            <group>admin:product:read</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="reviews">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="options">
-            <group>product:read</group>
-            <group>product:create</group>
-            <group>product:update</group>
+            <group>admin:product:read</group>
+            <group>admin:product:create</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="images">
-            <group>product:read</group>
-            <group>product:create</group>
-            <group>product:update</group>
+            <group>admin:product:read</group>
+            <group>admin:product:create</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="variants">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
     </class>
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductImage.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductImage.xml
@@ -6,10 +6,12 @@
 >
     <class name="Sylius\Component\Core\Model\ProductImage">
         <attribute name="id">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="path">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
     </class>
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductTranslation.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/ProductTranslation.xml
@@ -6,20 +6,23 @@
 >
     <class name="Sylius\Component\Product\Model\ProductTranslation">
         <attribute name="id">
-            <group>product:read</group>
+            <group>admin:product:read</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="name">
-            <group>product:read</group>
-            <group>product:create</group>
-            <group>product:update</group>
+            <group>admin:product:create</group>
+            <group>admin:product:read</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
         <attribute name="locale">
-            <group>product:create</group>
+            <group>admin:product:create</group>
         </attribute>
         <attribute name="slug">
-            <group>product:create</group>
-            <group>product:read</group>
-            <group>product:update</group>
+            <group>admin:product:create</group>
+            <group>admin:product:read</group>
+            <group>admin:product:update</group>
+            <group>shop:product:read</group>
         </attribute>
     </class>
 </serializer>