minor #12332 Reorganize UPGRADE-1.9 file to extract steps for Symfony…

… v5.2 (GSadee) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Commits ------- 16b9d64 Reorganize UPGRADE-1.9 file to extract steps for Symfony v5.2
Sylius · Feb 11, 2021 · 382f2ee · 382f2ee
2 parents 95bd502 + 16b9d64
commit 382f2ee
Showing 1 changed file with 52 additions and 32 deletions.
diff --git a/UPGRADE-1.9.md b/UPGRADE-1.9.md
@@ -2,32 +2,12 @@
 
 ### Package upgrades
 
-1. Add new bundles to your list of used bundles in `config/bundles.php` if they are not already there:
-
-    ```diff
-    +   BabDev\PagerfantaBundle\BabDevPagerfantaBundle::class => ['all' => true],
-    +   SyliusLabs\Polyfill\Symfony\Security\Bundle\SyliusLabsPolyfillSymfonySecurityBundle::class => ['all' => true],
+1. Upgrade the version of `friendsofsymfony/oauth-server-bundle` by:
 
-1. Remove `getContainerLoader` method from `src/Kernel.php` class if you did not customise it.
-
-1. We've removed the support for Symfony's Templating component (which is removed in Symfony 5). 
+    ```bash
+    composer require "friendsofsymfony/oauth-server-bundle" ">2.0.0-alpha.0 ^2.0@dev"
+    ```
 
-    * Remove `templating` from framework's configuration:
-
-        ```diff
-        # config/packages/framework.yaml
-
-        framework:
-            # ...
-        -    templating: { engines: ["twig"] }
-        ```
-      
-    * Replace any usages of `Symfony\Bundle\FrameworkBundle\Templating\EngineInterface` with `Twig\Environment`.
-
-        Inject `twig` service into your controllers instead of `templating`.
-
-        `$templating->renderResponse(...)` might be replaced with `new Response($twig->render(...))`.
-
 1. We've upgraded Sylius' ResourceBundle and GridBundle packages which forced us to upgrade major versions of our dependencies.
 
     Please follow [ResourceBundle's upgrade instructions](https://github.com/Sylius/SyliusResourceBundle/blob/master/UPGRADE.md#from-16x-to-17x).
@@ -38,14 +18,6 @@
     you can bring back old behaviour by overriding `error.json.twig` and `exception.json.twig` templates. You can check
     how we've done that in Sylius by looking into vendor code in `templates/bundles/TwigBundle/Exception/` directory. 
 
-1. Remove Twig route configuration from your `config/routes/dev/twig.yaml`:
-
-    ```diff
-    -   _errors:
-    -       resource: '@TwigBundle/Resources/config/routing/errors.xml'
-    -       prefix: /_error
-    ```
-
 1. We've replaced deprecated Doctrine Persistence API with the new one.
 
     Replace `Doctrine\Common\Persistence` namespace in your codebase to `Doctrine\Persistence`.
@@ -76,6 +48,54 @@
     +           permanent: false
     ```
 
+#### Upgrades Symfony to v5.2
+
+1. Upgrade Symfony dependencies by:
+
+    ```bash
+    composer config extra.symfony.require "^5.2"
+    composer require --dev "symfony/browser-kit" "^5.2" --no-update --no-scripts
+    composer require --dev "symfony/debug-bundle" "^5.2" --no-update --no-scripts
+    composer require --dev "symfony/intl" "^5.2" --no-update --no-scripts
+    composer require --dev "symfony/web-profiler-bundle" "^5.2" --no-update --no-scripts
+    composer update
+    ```
+
+1. Add new bundles to your list of used bundles in `config/bundles.php` if they are not already there:
+
+    ```diff
+    +   BabDev\PagerfantaBundle\BabDevPagerfantaBundle::class => ['all' => true],
+    +   SyliusLabs\Polyfill\Symfony\Security\Bundle\SyliusLabsPolyfillSymfonySecurityBundle::class => ['all' => true],
+    ```
+
+1. Remove `getContainerLoader` method from `src/Kernel.php` class if you did not customise it.
+
+1. We've removed the support for Symfony's Templating component (which is removed in Symfony 5). 
+
+    * Remove `templating` from framework's configuration:
+
+        ```diff
+        # config/packages/framework.yaml
+
+        framework:
+            # ...
+        -    templating: { engines: ["twig"] }
+        ```
+      
+    * Replace any usages of `Symfony\Bundle\FrameworkBundle\Templating\EngineInterface` with `Twig\Environment`.
+
+        Inject `twig` service into your controllers instead of `templating` or `templating.engine.twig`.
+
+        `$templating->renderResponse(...)` might be replaced with `new Response($twig->render(...))`.
+
+1. Remove Twig route configuration from your `config/routes/dev/twig.yaml`:
+
+    ```diff
+    -   _errors:
+    -       resource: '@TwigBundle/Resources/config/routing/errors.xml'
+    -       prefix: /_error
+    ```
+
 ### New API
 
 1. Adjust your `config/packages/security.yaml`.