Provide improvements after code review

Sylius · May 20, 2023 · 3eeac41 · 3eeac41
1 parent 1383ae6
commit 3eeac41
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/features/cli/removing_locale.feature b/features/cli/removing_locale.feature
@@ -1,8 +1,8 @@
 @removing_locale
 Feature: Removing locales
-    In order to deleting accidentally created locales
+    In order to delete accidentally created locales
     As a Developer
-    I want to have a way to remove a given locale
+    I want to be able to delete locales
 
     Background:
         Given the store operates on a channel named "Web" with hostname "web"
@@ -14,7 +14,7 @@ Feature: Removing locales
         Given the store has a product "T-Shirt banana"
         And this product is named "Banana T-Shirt with Minions" in the "English (United States)" locale
         And this product has no translation in the "Polish (Poland)" locale
-        When I run a command removing the "Polish (Poland)" locale
+        When I remove "Polish (Poland)" locale
         Then I should be informed that locale "Polish (Poland)" has been deleted
         And only the "English (United States)" locale should be present in the system
 

diff --git a/src/Sylius/Behat/Context/Cli/RemoveLocaleContext.php b/src/Sylius/Behat/Context/Cli/RemoveLocaleContext.php
@@ -40,7 +40,7 @@ public function __construct(
     }
 
     /**
-     * @When I run a command removing the :localeName locale
+     * @When I remove :localeCode locale
      */
     public function iRunACommandRemovingTheLocale(string $localeName): void
     {

diff --git a/src/Sylius/Bundle/CoreBundle/Command/RemoveLocaleCommand.php b/src/Sylius/Bundle/CoreBundle/Command/RemoveLocaleCommand.php
@@ -41,7 +41,7 @@ protected function configure(): void
             ->addArgument(name: 'locale', description: 'Locale code to remove')
             ->setHelp(
                 <<<EOT
-                The <info>%command.name%</info> command removes a locale from Sylius.
+                The <info>%command.name%</info> command can be used to remove an unused locale from Sylius.
                 EOT
             )
         ;