Resolve phpstan issues

Sylius · Nov 30, 2023 · 440a75a · 440a75a
1 parent 6d33557
commit 440a75a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 22 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -805,26 +805,6 @@ parameters:
 			count: 1
 			path: src/Sylius/Bundle/ApiBundle/DataPersister/ProductTaxonDataPersister.php
 
-		-
-			message: "#^Method Sylius\\\\Bundle\\\\ApiBundle\\\\DataPersister\\\\PromotionCouponDataPersister\\:\\:persist\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: src/Sylius/Bundle/ApiBundle/DataPersister/PromotionCouponDataPersister.php
-
-		-
-			message: "#^Method Sylius\\\\Bundle\\\\ApiBundle\\\\DataPersister\\\\PromotionCouponDataPersister\\:\\:remove\\(\\) has no return type specified\\.$#"
-			count: 1
-			path: src/Sylius/Bundle/ApiBundle/DataPersister/PromotionCouponDataPersister.php
-
-		-
-			message: "#^Method Sylius\\\\Bundle\\\\ApiBundle\\\\DataPersister\\\\PromotionCouponDataPersister\\:\\:remove\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: src/Sylius/Bundle/ApiBundle/DataPersister/PromotionCouponDataPersister.php
-
-		-
-			message: "#^Method Sylius\\\\Bundle\\\\ApiBundle\\\\DataPersister\\\\PromotionCouponDataPersister\\:\\:supports\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: src/Sylius/Bundle/ApiBundle/DataPersister/PromotionCouponDataPersister.php
-
 		-
 			message: "#^Method Sylius\\\\Bundle\\\\ApiBundle\\\\DataPersister\\\\ProductTaxonDataPersister\\:\\:remove\\(\\) has parameter \\$context with no value type specified in iterable type array\\.$#"
 			count: 1

diff --git a/src/Sylius/Bundle/ApiBundle/DataPersister/PromotionCouponDataPersister.php b/src/Sylius/Bundle/ApiBundle/DataPersister/PromotionCouponDataPersister.php
@@ -26,20 +26,23 @@ public function __construct(
     ) {
     }
 
+    /** @param array<array-key, mixed> $context */
     public function supports($data, array $context = []): bool
     {
         return $data instanceof PromotionCouponInterface;
     }
 
+    /** @param array<array-key, mixed> $context */
     public function persist($data, array $context = [])
     {
         return $this->decoratedDataPersister->persist($data, $context);
     }
 
-    public function remove($data, array $context = [])
+    /** @param array<array-key, mixed> $context */
+    public function remove($data, array $context = []): void
     {
         try {
-            return $this->decoratedDataPersister->remove($data, $context);
+            $this->decoratedDataPersister->remove($data, $context);
         } catch (ForeignKeyConstraintViolationException) {
             throw new PromotionCouponCannotBeRemoved();
         }