Revert BC break in ProductVariantInterface

Sylius · Apr 9, 2021 · 67bf126 · 67bf126
1 parent 03546d5
commit 67bf126
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Sylius/Component/Product/Model/ProductVariant.php b/src/Sylius/Component/Product/Model/ProductVariant.php
@@ -108,9 +108,9 @@ public function removeOptionValue(ProductOptionValueInterface $optionValue): voi
         }
     }
 
-    public function hasOptionValue(?ProductOptionValueInterface $optionValue): bool
+    public function hasOptionValue(ProductOptionValueInterface $optionValue): bool
     {
-        return $optionValue === null ? true : $this->optionValues->contains($optionValue);
+        return $this->optionValues->contains($optionValue);
     }
 
     public function getProduct(): ?ProductInterface

diff --git a/src/Sylius/Component/Product/Model/ProductVariantInterface.php b/src/Sylius/Component/Product/Model/ProductVariantInterface.php
@@ -45,7 +45,7 @@ public function addOptionValue(ProductOptionValueInterface $optionValue): void;
 
     public function removeOptionValue(ProductOptionValueInterface $optionValue): void;
 
-    public function hasOptionValue(?ProductOptionValueInterface $optionValue): bool;
+    public function hasOptionValue(ProductOptionValueInterface $optionValue): bool;
 
     public function getProduct(): ?ProductInterface;