Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Arminek committed Jun 23, 2016
1 parent 73f88ee commit 76aae77
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
*/
class SummaryNoteType extends AbstractResourceType
class SummaryType extends AbstractResourceType
{
/**
* {@inheritdoc}
Expand All @@ -35,6 +35,6 @@ public function buildForm(FormBuilderInterface $builder, array $options)
*/
public function getName()
{
return 'sylius_checkout_summary_note';
return 'sylius_checkout_summary';
}
}
6 changes: 3 additions & 3 deletions src/Sylius/Bundle/CoreBundle/Resources/config/form.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parameter key="sylius.checkout_form.shipping.class">Sylius\Bundle\CoreBundle\Form\Type\Checkout\ShippingStepType</parameter>
<parameter key="sylius.checkout_form.shop_addressing.class">Sylius\Bundle\CoreBundle\Form\Type\Checkout\AddressingType</parameter>
<parameter key="sylius.checkout_form.shop_shipping.class">Sylius\Bundle\CoreBundle\Form\Type\Checkout\ShippingType</parameter>
<parameter key="sylius.checkout_form.summary_note.class">Sylius\Bundle\CoreBundle\Form\Type\Checkout\SummaryNoteType</parameter>
<parameter key="sylius.checkout_form.summary.class">Sylius\Bundle\CoreBundle\Form\Type\Checkout\SummaryType</parameter>

<parameter key="sylius.form.type.image.class">Sylius\Bundle\CoreBundle\Form\Type\ImageType</parameter>
<parameter key="sylius.form.type.list.class">Sylius\Bundle\CoreBundle\Form\Type\ListType</parameter>
Expand Down Expand Up @@ -94,9 +94,9 @@
</argument>
<tag name="form.type" alias="sylius_checkout_payment_step" />
</service>
<service id="sylius_checkout_form.summary_note" class="%sylius.checkout_form.summary_note.class%">
<service id="sylius_checkout_form.summary" class="%sylius.checkout_form.summary.class%">
<argument>%sylius.model.cart.class%</argument>
<tag name="form.type" alias="sylius_checkout_summary_note" />
<tag name="form.type" alias="sylius_checkout_summary" />
</service>

<service id="sylius.form.type.cart" class="%sylius.form.type.cart.class%">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@

use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Sylius\Bundle\CoreBundle\Form\Type\Checkout\SummaryNoteType;
use Sylius\Bundle\CoreBundle\Form\Type\Checkout\SummaryType;
use Sylius\Bundle\ResourceBundle\Form\Type\AbstractResourceType;
use Symfony\Component\Form\FormBuilderInterface;

/**
* @mixin SummaryNoteType
* @mixin SummaryType
*
* @author Arkadiusz Krakowiak <arkadiusz.krakowiak@lakion.com>
*/
class SummaryNoteTypeSpec extends ObjectBehavior
class SummaryTypeSpec extends ObjectBehavior
{
function let()
{
Expand All @@ -31,7 +31,7 @@ function let()

function it_is_initializable()
{
$this->shouldHaveType('Sylius\Bundle\CoreBundle\Form\Type\Checkout\SummaryNoteType');
$this->shouldHaveType('Sylius\Bundle\CoreBundle\Form\Type\Checkout\SummaryType');
}

function it_is_a_resource_form_type()
Expand All @@ -48,6 +48,6 @@ function it_builds_form(FormBuilderInterface $builder)

function it_has_name()
{
$this->getName()->shouldReturn('sylius_checkout_summary_note');
$this->getName()->shouldReturn('sylius_checkout_summary');
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ sylius_shop_checkout_summary:
transition: create
redirect: sylius_shop_homepage
form:
type: sylius_checkout_summary_note
type: sylius_checkout_summary

0 comments on commit 76aae77

Please sign in to comment.