Fix checking whether an image exists

Sylius · Dec 7, 2020 · 84ba5f2 · 84ba5f2
1 parent 9670b46
commit 84ba5f2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Sylius/Behat/Page/Admin/Product/UpdateConfigurableProductPage.php b/src/Sylius/Behat/Page/Admin/Product/UpdateConfigurableProductPage.php
@@ -79,10 +79,10 @@ public function isImageWithTypeDisplayed(string $type): bool
         }
 
         $this->getDriver()->visit($imageUrl);
-        $pageText = $this->getDocument()->getText();
+        $statusCode = $this->getDriver()->getStatusCode();
         $this->getDriver()->back();
 
-        return false === stripos($pageText, '404 Not Found');
+        return strpos((string) $statusCode, '2') === 0;
     }
 
     public function attachImage(string $path, string $type = null): void

diff --git a/src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPage.php b/src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPage.php
@@ -152,10 +152,10 @@ public function isImageWithTypeDisplayed(string $type): bool
         }
 
         $this->getDriver()->visit($imageUrl);
-        $pageText = $this->getDocument()->getText();
+        $statusCode = $this->getDriver()->getStatusCode();
         $this->getDriver()->back();
 
-        return false === stripos($pageText, '404 Not Found');
+        return strpos((string) $statusCode, '2') === 0;
     }
 
     public function attachImage(string $path, string $type = null): void

diff --git a/src/Sylius/Behat/Page/Admin/Taxon/UpdatePage.php b/src/Sylius/Behat/Page/Admin/Taxon/UpdatePage.php
@@ -83,10 +83,10 @@ public function isImageWithTypeDisplayed(string $type): bool
         }
 
         $this->getDriver()->visit($imageUrl);
-        $pageText = $this->getDocument()->getText();
+        $statusCode = $this->getDriver()->getStatusCode();
         $this->getDriver()->back();
 
-        return false === stripos($pageText, '404 Not Found');
+        return strpos((string) $statusCode, '2') === 0;
     }
 
     public function isSlugReadonly(string $languageCode = 'en_US'): bool