Skip to content

Commit

Permalink
refactor #11162 [API] Minor fixes after tax categories api configured…
Browse files Browse the repository at this point in the history
… (AdamKasp)

This PR was merged into the api branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | API
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.6 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->


Commits
-------

226eba7 Minor fixes after tax categories api configured
  • Loading branch information
GSadee committed Mar 9, 2020
2 parents 38e84be + 226eba7 commit 8f5b54c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function iShouldNotBeAbleToEditItsCode(): void
* @Then /^(this tax category) name should be "([^"]+)"$/
* @Then /^(this tax category) should still be named "([^"]+)"$/
*/
public function thisTaxCategoryNameShouldBe(TaxCategoryInterface $taxCategory, $taxCategoryName): void
public function thisTaxCategoryNameShouldBe(TaxCategoryInterface $taxCategory, string $taxCategoryName): void
{
$this->client->show('tax_categories', $taxCategory->getCode());
Assert::true($this->client->responseHasValue('name', $taxCategoryName), sprintf('Tax category name is not %s', $taxCategoryName));
Expand Down
13 changes: 8 additions & 5 deletions src/Sylius/Behat/Resources/config/services/contexts/api.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@
<argument type="service" id="sylius.behat.shared_storage" />
</service>

<service id="sylius.behat.context.api.admin.managing_taxons" class="Sylius\Behat\Context\Api\Admin\ManagingTaxonsContext">
<service id="sylius.behat.context.api.admin.managing_product_variants" class="Sylius\Behat\Context\Api\Admin\ManagingProductVariantsContext">
<argument type="service" id="test.client" />
<argument type="service" id="session" />
</service>
<service id="sylius.behat.context.api.admin.managing_product_variants" class="Sylius\Behat\Context\Api\Admin\ManagingProductVariantsContext">

<service id="sylius.behat.context.api.admin.managing_tax_categories" class="Sylius\Behat\Context\Api\Admin\ManagingTaxCategoriesContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>

<service id="sylius.behat.context.api.admin.managing_taxons" class="Sylius\Behat\Context\Api\Admin\ManagingTaxonsContext">
<argument type="service" id="test.client" />
<argument type="service" id="session" />
</service>
Expand All @@ -49,9 +54,7 @@
<service id="sylius.behat.context.api.admin.notification" class="Sylius\Behat\Context\Api\Admin\NotificationContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>
<service id="sylius.behat.context.api.admin.managing_tax_categories" class="Sylius\Behat\Context\Api\Admin\ManagingTaxCategoriesContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>

<service id="sylius.behat.context.api.admin.managing_customer_groups" class="Sylius\Behat\Context\Api\Admin\ManagingCustomerGroupsContext">
<argument type="service" id="Sylius\Behat\Client\ApiClientInterface" />
</service>
Expand Down

0 comments on commit 8f5b54c

Please sign in to comment.