Skip to content

Commit

Permalink
Remove unneeded placeholder from zone's scope select (#16226)
Browse files Browse the repository at this point in the history
| Q               | A
|-----------------|-----
| Branch?         | 1.12 <!-- see the comment below -->
| Bug fix?        | a bit
| New feature?    | no
| BC breaks?      | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
![Screenshot 2024-05-07 at 12 05
25](https://github.com/Sylius/Sylius/assets/53942444/67c35100-11a7-48bd-9e0a-76579aacf792)
![Screenshot 2024-05-07 at 12 05
32](https://github.com/Sylius/Sylius/assets/53942444/f93d4409-abaf-48df-936d-5bdcea27c17f)
  • Loading branch information
Wojdylak committed May 7, 2024
2 parents 10ced44 + a353a97 commit 9b7e954
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/Sylius/Bundle/AddressingBundle/Form/Type/ZoneType.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
->add('scope', ChoiceType::class, [
'choices' => array_flip($this->scopeChoices),
'label' => 'sylius.form.zone.scope',
'placeholder' => 'sylius.form.zone.select_scope',
'placeholder' => null,
'required' => false,
])
;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,5 @@ sylius:
scopes:
all: All
select: Select
select_scope: Select scope
zone_member:
select: Select

0 comments on commit 9b7e954

Please sign in to comment.