Skip to content

Commit

Permalink
Merge branch '1.7'
Browse files Browse the repository at this point in the history
* 1.7:
  Making error messages in example factories more descriptive
  Fix route id typo
  • Loading branch information
lchrusciel committed May 22, 2020
2 parents 552c4a0 + a01e2ba commit a00d41e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/customization/controller.rst
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ If you still need the methods of the original ``HomepageController``, then copy

.. code-block:: yaml
app_shop_custom_procuct:
app_shop_custom_product:
path: /custom/product
methods: [GET]
defaults:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public function create(array $options = []): AddressInterface
private function assertCountryCodeIsValid(string $code): void
{
$country = $this->countryRepository->findOneBy(['code' => $code]);
Assert::notNull($country);
Assert::notNull($country, sprintf('Trying to create address with invalid country code: "%s"', $code));
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ private function configureProductAttributeValue(string $code, string $localeCode
/** @var ProductAttributeInterface|null $productAttribute */
$productAttribute = $this->productAttributeRepository->findOneBy(['code' => $code]);

Assert::notNull($productAttribute);
Assert::notNull($productAttribute, sprintf('Can not find product attribute with code: "%s"', $code));

/** @var ProductAttributeValueInterface $productAttributeValue */
$productAttributeValue = $this->productAttributeValueFactory->createNew();
Expand Down

0 comments on commit a00d41e

Please sign in to comment.