Merge pull request #7780 from pamil/form-types-promotion

Decouple promotion components from bundles and cleanup promotion forms

UPGRADE.md

@@ -200,6 +200,11 @@ You can bring back previous configuration by overriding current routing with you
 
 * Removed class `Sylius\Bundle\CoreBundle\Form\Type\ProductTaxonChoiceType`, use `Sylius\Bundle\CoreBundle\Form\Type\Taxon\ProductTaxonAutocompleteChoiceType` instead.
 
+* Removed `Sylius\Component\Core\Promotion\Action\ChannelBasedPromotionActionCommandInterface` and 
+  `Sylius\Component\Core\Promotion\Checker\Rule\ChannelBasedRuleCheckerInterface` interfaces as they are not needed anymore.
+
+* Removed `Sylius\Bundle\CoreBundle\Form\Type\Promotion\PromotionConfigurationType` class as it has no behaviour and is not used.
+
 ### Currency / CurrencyBundle
 
 * The following classes were removed due to being no longer used in current implementation:

src/Sylius/Behat/Page/Admin/Promotion/CreatePage.php

@@ -229,7 +229,7 @@ private function getChannelConfigurationOfLastAction($channelName)
     {
         return $this
             ->getLastCollectionItem('actions')
-            ->find('css', sprintf('[id*="sylius_promotion_actions"] .configuration .field:contains("%s")', $channelName))
+            ->find('css', sprintf('[id$="configuration"] .field:contains("%s")', $channelName))
         ;
     }
 
@@ -242,7 +242,7 @@ private function getChannelConfigurationOfLastRule($channelName)
     {
         return $this
             ->getLastCollectionItem('rules')
-            ->find('css', sprintf('[id*="sylius_promotion_rules"] .configuration .field:contains("%s")', $channelName))
+            ->find('css', sprintf('[id$="configuration"] .field:contains("%s")', $channelName))
         ;
     }