feature #13068 [CatalogPromotions][Api] Add test for creation rule (T…

…omanhez)

This PR was merged into the 1.11-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

73e22d3 Add test for creation rule

features/promotion/managing_catalog_promotions/validating_catalog_promotion_creation.feature

@@ -49,7 +49,7 @@ Feature: Validating a catalog promotion creation
         Then I should be notified that rule configuration is invalid
         And there should be an empty list of catalog promotions
 
-    @api
+    @api @ui @javascript
     Scenario: Trying to create a catalog promotion with not configured for variants rule
         When I want to create a new catalog promotion
         And I specify its code as "winter_sale"

src/Sylius/Behat/Context/Ui/Admin/ManagingCatalogPromotionsContext.php

@@ -18,11 +18,8 @@
 use Sylius\Behat\Page\Admin\CatalogPromotion\CreatePageInterface;
 use Sylius\Behat\Page\Admin\CatalogPromotion\UpdatePageInterface;
 use Sylius\Behat\Page\Admin\Crud\IndexPageInterface;
-use Sylius\Behat\Service\SharedStorageInterface;
 use Sylius\Component\Core\Model\CatalogPromotionInterface;
-use Sylius\Component\Core\Model\CatalogPromotionRuleInterface;
 use Sylius\Component\Core\Model\ProductVariantInterface;
-use Sylius\Component\Promotion\Model\CatalogPromotionActionInterface;
 use Webmozart\Assert\Assert;
 
 final class ManagingCatalogPromotionsContext implements Context
@@ -35,20 +32,16 @@ final class ManagingCatalogPromotionsContext implements Context
 
     private FormElementInterface $formElement;
 
-    private SharedStorageInterface $sharedStorage;
-
     public function __construct(
         IndexPageInterface $indexPage,
         CreatePageInterface $createPage,
         UpdatePageInterface $updatePage,
-        FormElementInterface $formElement,
-        SharedStorageInterface $sharedStorage
+        FormElementInterface $formElement
     ) {
         $this->indexPage = $indexPage;
         $this->createPage = $createPage;
         $this->updatePage = $updatePage;
         $this->formElement = $formElement;
-        $this->sharedStorage = $sharedStorage;
     }
 
     /**
@@ -158,7 +151,7 @@ public function iAddActionThatGivesPercentageDiscount(string $discount): void
     }
 
     /**
-     * @When I add it
+     * @When I (try to) add it
      */
     public function iAddIt(): void
     {
@@ -214,6 +207,14 @@ public function iEditCatalogPromotionToHaveDiscount(CatalogPromotionInterface $c
         $this->updatePage->saveChanges();
     }
 
+    /**
+     * @When I add for variants rule without variants configured
+     */
+    public function iAddForVariantsRuleWithoutVariantsConfigured(): void
+    {
+        $this->formElement->addRule();
+    }
+
     /**
      * @Then there should be :amount catalog promotions on the list
      * @Then there should be :amount new catalog promotion on the list
@@ -401,4 +402,12 @@ public function iShouldNotBeAbleToEditItsCode(): void
     {
         Assert::true($this->updatePage->isCodeDisabled());
     }
+
+    /**
+     * @Then I should be notified that at least 1 variant is required
+     */
+    public function iShouldBeNotifiedThatAtLeast1VariantIsRequired(): void
+    {
+        Assert::same($this->formElement->getValidationMessageForAction(), 'Please add at least 1 variant.');
+    }
 }

src/Sylius/Behat/Element/Admin/CatalogPromotion/FormElement.php

@@ -14,6 +14,7 @@
 namespace Sylius\Behat\Element\Admin\CatalogPromotion;
 
 use Behat\Mink\Element\NodeElement;
+use Behat\Mink\Exception\ElementNotFoundException;
 use FriendsOfBehat\PageObjectExtension\Element\Element;
 use Webmozart\Assert\Assert;
 
@@ -87,6 +88,17 @@ public function getLastActionDiscount(): string
         return $lastAction->find('css', 'input')->getValue();
     }
 
+    public function getValidationMessageForAction(): string
+    {
+        $foundElement = $this->getDocument()->find('css', '.sylius-validation-error');
+
+        if (null === $foundElement) {
+            throw new ElementNotFoundException($this->getSession(), 'Tag', 'css', '.sylius-validation-error');
+        }
+
+        return $foundElement->getText();
+    }
+
     protected function getDefinedElements(): array
     {
         return array_merge(parent::getDefinedElements(), [

src/Sylius/Behat/Element/Admin/CatalogPromotion/FormElementInterface.php

@@ -38,4 +38,6 @@ public function getFieldValueInLocale(string $field, string $localeCode): string
     public function getLastRuleVariantCodes(): array;
 
     public function getLastActionDiscount(): string;
+
+    public function getValidationMessageForAction(): string;
 }

src/Sylius/Behat/Resources/config/services/contexts/ui.xml

@@ -50,7 +50,6 @@
             <argument type="service" id="sylius.behat.page.admin.catalog_promotion.create" />
             <argument type="service" id="sylius.behat.page.admin.catalog_promotion.update" />
             <argument type="service" id="Sylius\Behat\Element\Admin\CatalogPromotion\FormElement" />
-            <argument type="service" id="sylius.behat.shared_storage" />
         </service>
 
         <service id="sylius.behat.context.ui.admin.managing_channels" class="Sylius\Behat\Context\Ui\Admin\ManagingChannelsContext">

src/Sylius/Bundle/AdminBundle/Resources/views/CatalogPromotion/_form.html.twig

@@ -3,8 +3,8 @@
 {% form_theme form '@SyliusAdmin/CatalogPromotion/theme.html.twig' %}
 
 <div class="ui two column stackable grid">
-    {{ form_errors(form) }}
     <div class="column">
+        {{ form_errors(form) }}
         <div class="ui segment">
             {{ form_row(form.code) }}
             {{ form_row(form.name) }}