Provide post-CR fixes

Sylius · Jun 28, 2023 · d61ef59 · d61ef59
1 parent 716e8c5
commit d61ef59
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 15 deletions.
diff --git a/features/account/receiving_email_after_registration.feature b/features/account/receiving_email_after_registration.feature
@@ -21,7 +21,7 @@ Feature: Receiving a welcoming email after registration
         When I register with email "ghastly@bespoke.com" and password "suitsarelife"
         Then only one email should have been sent to "ghastly@bespoke.com"
         And a verification email should have been sent to "ghastly@bespoke.com"
-        And a welcoming email should not have been sent to "ghastly@bespoke.com"
+        But a welcoming email should not have been sent to "ghastly@bespoke.com"
 
     @ui @email @api
     Scenario: Receiving a welcoming email after registration in different locale than the default one

diff --git a/src/Sylius/Behat/Context/Api/EmailContext.php b/src/Sylius/Behat/Context/Api/EmailContext.php
@@ -192,7 +192,7 @@ public function recipientShouldReceiveNoEmails(string $recipient): void
     }
 
     /**
-     * @Then /^only one email should have been sent to "([^"]*)"$/
+     * @Then only one email should have been sent to :recipientEmail
      */
     public function onlyOneEmailShouldHaveBeenSentTo(string $recipient): void
     {

diff --git a/src/Sylius/Behat/Context/Api/Shop/RegistrationContext.php b/src/Sylius/Behat/Context/Api/Shop/RegistrationContext.php
@@ -252,19 +252,11 @@ public function iShouldBeSubscribedToTheNewsletter(): void
     }
 
     /**
-     * @Then /^I should be on registration thank you page$/
+     * @Then I should be on my account dashboard
+     * @Then I should be on registration thank you page
      */
-    public function iShouldBeOnRegistrationThankYouPage(): void
+    public function intentionallyLeftBlank(): void
     {
-        // Intentionally left blank
-    }
-
-    /**
-     * @Then /^I should be on my account dashboard/
-     */
-    public function iShouldBeOnMyAccountDashboard(): void
-    {
-        // Intentionally left blank
     }
 
     private function assertFieldValidationMessage(string $path, string $message): void

diff --git a/src/Sylius/Behat/Context/Ui/Shop/Checkout/RegistrationAfterCheckoutContext.php b/src/Sylius/Behat/Context/Ui/Shop/Checkout/RegistrationAfterCheckoutContext.php
@@ -101,7 +101,7 @@ public function iShouldBeAbleToLogInAsWithPassword(string $email, string $passwo
     }
 
     /**
-     * @Then /^I should be on registration thank you page$/
+     * @Then I should be on registration thank you page
      */
     public function iShouldBeOnRegistrationThankYouPage(): void
     {

diff --git a/src/Sylius/Behat/Page/Shop/Account/RegisterThankYouPageInterface.php b/src/Sylius/Behat/Page/Shop/Account/RegisterThankYouPageInterface.php
@@ -6,5 +6,4 @@
 
 interface RegisterThankYouPageInterface extends SymfonyPageInterface
 {
-
 }