[Behat] Fix CS after introducing PHP 7.4 syntax

Sylius · May 31, 2022 · e3961b0 · e3961b0
1 parent 5477cd0
commit e3961b0
Show file tree

Hide file tree

Showing 25 changed files with 38 additions and 38 deletions.
diff --git a/src/Sylius/Behat/Client/ResponseChecker.php b/src/Sylius/Behat/Client/ResponseChecker.php
@@ -36,7 +36,7 @@ public function getCollection(Response $response): array
 
     public function getCollectionItemsWithValue(Response $response, string $key, string $value): array
     {
-        $items = array_filter($this->getCollection($response), fn(array $item): bool => $item[$key] === $value);
+        $items = array_filter($this->getCollection($response), fn (array $item): bool => $item[$key] === $value);
 
         return $items;
     }

diff --git a/src/Sylius/Behat/Context/Api/Admin/AjaxContext.php b/src/Sylius/Behat/Context/Api/Admin/AjaxContext.php
@@ -63,7 +63,7 @@ public function iShouldSeeProductVariantsInTheList($number): void
      */
     public function iShouldSeeTheProductVariantNamedAnd(...$names): void
     {
-        $itemsNames = array_map(static fn($item) => strstr($item['descriptor'], ' ', true), $this->getJSONResponse());
+        $itemsNames = array_map(static fn ($item) => strstr($item['descriptor'], ' ', true), $this->getJSONResponse());
 
         Assert::allOneOf($itemsNames, $names);
     }

diff --git a/src/Sylius/Behat/Context/Setup/ProductContext.php b/src/Sylius/Behat/Context/Setup/ProductContext.php
@@ -676,7 +676,7 @@ public function thisProductSizeBelongsToShippingCategory(ProductInterface $produ
     {
         $code = sprintf('%s_%s', $product->getCode(), $optionValueName);
         /** @var ProductVariantInterface $productVariant */
-        $productVariant = $product->getVariants()->filter(fn($variant) => $code === $variant->getCode())->first();
+        $productVariant = $product->getVariants()->filter(fn ($variant) => $code === $variant->getCode())->first();
 
         Assert::notNull($productVariant, sprintf('Product variant with given code %s not exists!', $code));
 

diff --git a/src/Sylius/Behat/Context/Transform/ProductContext.php b/src/Sylius/Behat/Context/Transform/ProductContext.php
@@ -54,6 +54,6 @@ public function getProductByName($productName)
      */
     public function getProductsByNames(...$productsNames)
     {
-        return array_map(fn($productName) => $this->getProductByName($productName), $productsNames);
+        return array_map(fn ($productName) => $this->getProductByName($productName), $productsNames);
     }
 }
diff --git a/src/Sylius/Behat/Context/Transform/ShippingCalculatorContext.php b/src/Sylius/Behat/Context/Transform/ShippingCalculatorContext.php
@@ -34,7 +34,7 @@ public function __construct(array $shippingCalculators, TranslatorInterface $tra
     public function getShippingCalculatorByName(string $shippingCalculator): string
     {
         $flippedCalculators = array_flip(array_map(
-            fn(string $translationKey): string => $this->translator->trans($translationKey),
+            fn (string $translationKey): string => $this->translator->trans($translationKey),
             $this->shippingCalculators
         ));
 

diff --git a/src/Sylius/Behat/Context/Ui/Admin/ManagingCatalogPromotionsContext.php b/src/Sylius/Behat/Context/Ui/Admin/ManagingCatalogPromotionsContext.php
@@ -233,7 +233,7 @@ public function iAddANewCatalogPromotionScope(): void
      */
     public function iAddScopeThatAppliesOnVariants(ProductVariantInterface ...$variants): void
     {
-        $variantCodes = array_map(fn(ProductVariantInterface $variant) => $variant->getCode(), $variants);
+        $variantCodes = array_map(fn (ProductVariantInterface $variant) => $variant->getCode(), $variants);
 
         $this->formElement->addScope();
         $this->formElement->chooseScopeType('For variants');
@@ -245,7 +245,7 @@ public function iAddScopeThatAppliesOnVariants(ProductVariantInterface ...$varia
      */
     public function iAddScopeThatAppliesOnTaxons(TaxonInterface ...$taxons): void
     {
-        $taxonsCodes = array_map(fn(TaxonInterface $taxon) => $taxon->getCode(), $taxons);
+        $taxonsCodes = array_map(fn (TaxonInterface $taxon) => $taxon->getCode(), $taxons);
 
         $this->formElement->addScope();
         $this->formElement->chooseScopeType('For taxons');

diff --git a/src/Sylius/Behat/Element/Admin/CatalogPromotion/FormElement.php b/src/Sylius/Behat/Element/Admin/CatalogPromotion/FormElement.php
@@ -228,7 +228,7 @@ private function addCollectionElement(string $collectionElement, string $buttonE
 
         $this->getElement($buttonElement)->click();
 
-        $this->getDocument()->waitFor(5, fn() => $count + 1 === count($this->getCollectionItems($collectionElement)));
+        $this->getDocument()->waitFor(5, fn () => $count + 1 === count($this->getCollectionItems($collectionElement)));
     }
 
     /** @return NodeElement[] */

diff --git a/src/Sylius/Behat/Element/Product/IndexPage/VerticalMenuElement.php b/src/Sylius/Behat/Element/Product/IndexPage/VerticalMenuElement.php
@@ -22,7 +22,7 @@ public function getMenuItems(): array
     {
         $menu = $this->getElement('vertical-menu');
 
-        return array_map(fn(NodeElement $element): string => $element->getText(), $menu->findAll('css', '[data-test-vertical-menu-item]'));
+        return array_map(fn (NodeElement $element): string => $element->getText(), $menu->findAll('css', '[data-test-vertical-menu-item]'));
     }
 
     public function canNavigateToParentTaxon(): bool

diff --git a/src/Sylius/Behat/Element/Shop/MenuElement.php b/src/Sylius/Behat/Element/Shop/MenuElement.php
@@ -22,7 +22,7 @@ public function getMenuItems(): array
     {
         $menu = $this->getElement('menu');
 
-        return array_map(fn(NodeElement $element): string => $element->getText(), $menu->findAll('css', '[data-test-menu-item]'));
+        return array_map(fn (NodeElement $element): string => $element->getText(), $menu->findAll('css', '[data-test-menu-item]'));
     }
 
     protected function getDefinedElements(): array

diff --git a/src/Sylius/Behat/Page/Admin/Customer/ShowPage.php b/src/Sylius/Behat/Page/Admin/Customer/ShowPage.php
@@ -186,7 +186,7 @@ private function getStatisticsForChannel(string $channelName): NodeElement
             ->findAll('css', '.row > .column > .statistic > .sylius-channel-name')
         ;
 
-        $statisticsRibs = array_filter($statisticsRibs, fn(NodeElement $statistic) => $channelName === trim($statistic->getText()));
+        $statisticsRibs = array_filter($statisticsRibs, fn (NodeElement $statistic) => $channelName === trim($statistic->getText()));
 
         $actualStatisticsCount = count($statisticsRibs);
         Assert::same(

diff --git a/src/Sylius/Behat/Page/Admin/Product/CreateSimpleProductPage.php b/src/Sylius/Behat/Page/Admin/Product/CreateSimpleProductPage.php
@@ -169,7 +169,7 @@ public function associateProducts(ProductAssociationTypeInterface $productAssoci
         $dropdown->click();
 
         foreach ($productsNames as $productName) {
-            $dropdown->waitFor(5, fn() => $this->hasElement('association_dropdown_item', [
+            $dropdown->waitFor(5, fn () => $this->hasElement('association_dropdown_item', [
                 '%association%' => $productAssociationType->getName(),
                 '%item%' => $productName,
             ]));
@@ -292,7 +292,7 @@ private function selectElementFromAttributesDropdown(string $id): void
     private function waitForFormElement(int $timeout = 5): void
     {
         $form = $this->getElement('form');
-        $this->getDocument()->waitFor($timeout, fn() => false === strpos($form->getAttribute('class'), 'loading'));
+        $this->getDocument()->waitFor($timeout, fn () => false === strpos($form->getAttribute('class'), 'loading'));
     }
 
     private function clickTabIfItsNotActive(string $tabName): void

diff --git a/src/Sylius/Behat/Page/Admin/Product/IndexPerTaxonPage.php b/src/Sylius/Behat/Page/Admin/Product/IndexPerTaxonPage.php
@@ -46,7 +46,7 @@ public function savePositions(): void
         $saveConfigurationButton = $this->getElement('save_configuration_button');
         $saveConfigurationButton->press();
 
-        $this->getDocument()->waitFor(5, fn() => null === $saveConfigurationButton->find('css', '.loading'));
+        $this->getDocument()->waitFor(5, fn () => null === $saveConfigurationButton->find('css', '.loading'));
     }
 
     protected function getDefinedElements(): array

diff --git a/src/Sylius/Behat/Page/Admin/Product/UpdateConfigurableProductPage.php b/src/Sylius/Behat/Page/Admin/Product/UpdateConfigurableProductPage.php
@@ -57,7 +57,7 @@ public function selectMainTaxon(TaxonInterface $taxon): void
 
         $this->getDriver()->executeScript(sprintf('$(\'input.search\').val(\'%s\')', $taxon->getName()));
         $this->getElement('search')->click();
-        $this->getElement('search')->waitFor(10, fn() => $this->hasElement('search_item_selected'));
+        $this->getElement('search')->waitFor(10, fn () => $this->hasElement('search_item_selected'));
         $itemSelected = $this->getElement('search_item_selected');
         $itemSelected->click();
     }

diff --git a/src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPage.php b/src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPage.php
@@ -62,7 +62,7 @@ public function addSelectedAttributes(): void
 
         $form = $this->getDocument()->find('css', 'form');
 
-        $this->getDocument()->waitFor(1, fn() => $form->hasClass('loading'));
+        $this->getDocument()->waitFor(1, fn () => $form->hasClass('loading'));
     }
 
     public function removeAttribute(string $attributeName, string $localeCode): void
@@ -284,7 +284,7 @@ public function associateProducts(ProductAssociationTypeInterface $productAssoci
         $dropdown->click();
 
         foreach ($productsNames as $productName) {
-            $dropdown->waitFor(5, fn() => $this->hasElement('association_dropdown_item', [
+            $dropdown->waitFor(5, fn () => $this->hasElement('association_dropdown_item', [
                 '%association%' => $productAssociationType->getName(),
                 '%item%' => $productName,
             ]));

diff --git a/src/Sylius/Behat/Page/Admin/ProductVariant/IndexPage.php b/src/Sylius/Behat/Page/Admin/ProductVariant/IndexPage.php
@@ -50,7 +50,7 @@ public function savePositions(): void
     {
         $this->getElement('save_configuration_button')->press();
 
-        $this->getDocument()->waitFor(5, fn() => null === $this->getElement('save_configuration_button')->find('css', '.loading'));
+        $this->getDocument()->waitFor(5, fn () => null === $this->getElement('save_configuration_button')->find('css', '.loading'));
     }
 
     protected function getDefinedElements(): array

diff --git a/src/Sylius/Behat/Page/Admin/Promotion/CreatePage.php b/src/Sylius/Behat/Page/Admin/Promotion/CreatePage.php
@@ -32,7 +32,7 @@ public function addRule(?string $ruleName): void
 
         $this->getDocument()->clickLink('Add rule');
 
-        $this->getDocument()->waitFor(5, fn() => $count + 1 === count($this->getCollectionItems('rules')));
+        $this->getDocument()->waitFor(5, fn () => $count + 1 === count($this->getCollectionItems('rules')));
 
         if (null !== $ruleName) {
             $this->selectRuleOption('Type', $ruleName);
@@ -80,7 +80,7 @@ public function addAction(?string $actionName): void
 
         $this->getDocument()->clickLink('Add action');
 
-        $this->getDocument()->waitFor(5, fn() => $count + 1 === count($this->getCollectionItems('actions')));
+        $this->getDocument()->waitFor(5, fn () => $count + 1 === count($this->getCollectionItems('actions')));
 
         if (null !== $actionName) {
             $this->selectActionOption('Type', $actionName);

diff --git a/src/Sylius/Behat/Page/Admin/ShippingMethod/CreatePage.php b/src/Sylius/Behat/Page/Admin/ShippingMethod/CreatePage.php
@@ -96,7 +96,7 @@ public function addRule(string $ruleName): void
 
         $this->getDocument()->clickLink('Add rule');
 
-        $this->getDocument()->waitFor(5, fn() => $count + 1 === count($this->getCollectionItems('rules')));
+        $this->getDocument()->waitFor(5, fn () => $count + 1 === count($this->getCollectionItems('rules')));
 
         $this->selectRuleOption('Type', $ruleName);
     }

diff --git a/src/Sylius/Behat/Page/Admin/Taxon/UpdatePage.php b/src/Sylius/Behat/Page/Admin/Taxon/UpdatePage.php
@@ -199,7 +199,7 @@ public function activateLanguageTab(string $locale): void
             $languageTabTitle->click();
         }
 
-        $this->getDocument()->waitFor(10, fn() => $languageTabTitle->hasClass('active'));
+        $this->getDocument()->waitFor(10, fn () => $languageTabTitle->hasClass('active'));
     }
 
     public function enable(): void

diff --git a/src/Sylius/Behat/Page/Admin/Zone/CreatePage.php b/src/Sylius/Behat/Page/Admin/Zone/CreatePage.php
@@ -40,7 +40,7 @@ public function checkValidationMessageForMembers(string $message): bool
 
     public function chooseMember(string $name): void
     {
-        $selectItems = $this->getDocument()->waitFor(2, fn() => $this->getDocument()->findAll('css', 'div[data-form-type="collection"] select'));
+        $selectItems = $this->getDocument()->waitFor(2, fn () => $this->getDocument()->findAll('css', 'div[data-form-type="collection"] select'));
         $lastSelectItem = end($selectItems);
 
         if (false === $lastSelectItem) {

diff --git a/src/Sylius/Behat/Page/Shop/Account/AddressBook/UpdatePage.php b/src/Sylius/Behat/Page/Shop/Account/AddressBook/UpdatePage.php
@@ -94,6 +94,6 @@ protected function getDefinedElements(): array
 
     private function waitForElement(int $timeout, string $elementName): void
     {
-        $this->getDocument()->waitFor($timeout, fn() => $this->hasElement($elementName));
+        $this->getDocument()->waitFor($timeout, fn () => $this->hasElement($elementName));
     }
 }
diff --git a/src/Sylius/Behat/Page/Shop/Cart/SummaryPage.php b/src/Sylius/Behat/Page/Shop/Cart/SummaryPage.php
@@ -224,7 +224,7 @@ public function updateCart(): void
 
     public function waitForRedirect(int $timeout): void
     {
-        $this->getDocument()->waitFor($timeout, fn() => $this->isOpen());
+        $this->getDocument()->waitFor($timeout, fn () => $this->isOpen());
     }
 
     public function getPromotionCouponValidationMessage(): string

diff --git a/src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php b/src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php
@@ -169,7 +169,7 @@ public function signIn(): void
 
     public function specifyPassword(string $password): void
     {
-        $this->getDocument()->waitFor(5, fn() => $this->getElement('login_password')->isVisible());
+        $this->getDocument()->waitFor(5, fn () => $this->getElement('login_password')->isVisible());
 
         $this->getElement('login_password')->setValue($password);
     }
@@ -231,7 +231,7 @@ public function selectShippingAddressFromAddressBook(AddressInterface $address):
         $addressBookSelect = $this->getElement('shipping_address_book');
 
         $addressBookSelect->click();
-        $addressOption = $addressBookSelect->waitFor(5, fn() => $addressBookSelect->find('css', sprintf('[data-test-address-book-item][data-id="%s"]', $address->getId())));
+        $addressOption = $addressBookSelect->waitFor(5, fn () => $addressBookSelect->find('css', sprintf('[data-test-address-book-item][data-id="%s"]', $address->getId())));
 
         if (null === $addressOption) {
             throw new ElementNotFoundException($this->getDriver(), 'option', 'css', sprintf('[data-test-address-book-item][data-id="%s"]', $address->getId()));
@@ -246,7 +246,7 @@ public function selectBillingAddressFromAddressBook(AddressInterface $address):
         $addressBookSelect = $this->getElement('billing_address_book');
 
         $addressBookSelect->click();
-        $addressOption = $addressBookSelect->waitFor(5, fn() => $addressBookSelect->find('css', sprintf('[data-test-address-book-item][data-id="%s"]', $address->getId())));
+        $addressOption = $addressBookSelect->waitFor(5, fn () => $addressBookSelect->find('css', sprintf('[data-test-address-book-item][data-id="%s"]', $address->getId())));
 
         if (null === $addressOption) {
             throw new ElementNotFoundException($this->getDriver(), 'option', 'css', sprintf('[data-test-address-book-item][data-id="%s"]', $address->getId()));
@@ -319,7 +319,7 @@ private function getOptionsFromSelect(NodeElement $element): array
     {
         return array_map(
             /** @return string[] */
-            static fn(NodeElement $element): string => $element->getText(),
+            static fn (NodeElement $element): string => $element->getText(),
             $element->findAll('css', 'option[value!=""]')
         );
     }
@@ -383,12 +383,12 @@ private function getFieldElement(string $element): ?NodeElement
 
     private function waitForLoginAction(): bool
     {
-        return $this->getDocument()->waitFor(5, fn() => !$this->hasElement('login_password'));
+        return $this->getDocument()->waitFor(5, fn () => !$this->hasElement('login_password'));
     }
 
     private function waitForElement(int $timeout, string $elementName): bool
     {
-        return $this->getDocument()->waitFor($timeout, fn() => $this->hasElement($elementName));
+        return $this->getDocument()->waitFor($timeout, fn () => $this->hasElement($elementName));
     }
 
     private function assertAddressType(string $type): void

diff --git a/src/Sylius/Behat/Page/Shop/HomePage.php b/src/Sylius/Behat/Page/Shop/HomePage.php
@@ -56,7 +56,7 @@ public function getActiveCurrency(): string
     public function getAvailableCurrencies(): array
     {
         return array_map(
-            fn(NodeElement $element) => $element->getText(),
+            fn (NodeElement $element) => $element->getText(),
             $this->getElement('currency_selector')->findAll('css', '[data-test-available-currency]')
         );
     }
@@ -79,7 +79,7 @@ public function getActiveLocale(): string
     public function getAvailableLocales(): array
     {
         return array_map(
-            fn(NodeElement $element) => $element->getText(),
+            fn (NodeElement $element) => $element->getText(),
             $this->getElement('locale_selector')->findAll('css', '[data-test-available-locale]')
         );
     }
@@ -92,7 +92,7 @@ public function switchLocale($localeCode): void
     public function getLatestProductsNames(): array
     {
         return array_map(
-            fn(NodeElement $element) => $element->getText(),
+            fn (NodeElement $element) => $element->getText(),
             $this->getElement('latest_products')->findAll('css', '[data-test-product-name]')
         );
     }

diff --git a/src/Sylius/Behat/Page/Shop/Product/ShowPage.php b/src/Sylius/Behat/Page/Shop/Product/ShowPage.php
@@ -151,7 +151,7 @@ public function getCatalogPromotionNames(): array
         $productPriceContent = $this->getElement('product_price_content');
         $catalogPromotions = $productPriceContent->findAll('css', '.promotion_label');
 
-        return array_map(fn(NodeElement $element): string => $element->getText(), $catalogPromotions);
+        return array_map(fn (NodeElement $element): string => $element->getText(), $catalogPromotions);
     }
 
     public function getCurrentUrl(): string
@@ -339,7 +339,7 @@ public function getOptionValues(string $optionCode): array
         $optionElement = $this->getElement('option_select', ['%optionCode%' => strtoupper($optionCode)]);
 
         return array_map(
-            fn(NodeElement $element) => $element->getText(),
+            fn (NodeElement $element) => $element->getText(),
             $optionElement->findAll('css', 'option')
         );
     }
@@ -383,7 +383,7 @@ private function waitForCartSummary(): void
     {
         if ($this->getDriver() instanceof Selenium2Driver || $this->getDriver() instanceof ChromeDriver) {
             JQueryHelper::waitForAsynchronousActionsToFinish($this->getSession());
-            $this->getDocument()->waitFor(3, fn(): bool => $this->summaryPage->isOpen());
+            $this->getDocument()->waitFor(3, fn (): bool => $this->summaryPage->isOpen());
         }
     }
 }
diff --git a/src/Sylius/Behat/Service/JQueryHelper.php b/src/Sylius/Behat/Service/JQueryHelper.php
@@ -26,6 +26,6 @@ public static function waitForAsynchronousActionsToFinish(Session $session): voi
     public static function waitForFormToStopLoading(DocumentElement $document, int $timeout = 10): void
     {
         $form = $document->find('css', 'form');
-        $document->waitFor($timeout, fn() => !$form->hasClass('loading'));
+        $document->waitFor($timeout, fn () => !$form->hasClass('loading'));
     }
 }