Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BuildFix] Fix AbstractMigration use statement #10163

Merged
merged 1 commit into from
Feb 11, 2019
Merged

[BuildFix] Fix AbstractMigration use statement #10163

merged 1 commit into from
Feb 11, 2019

Conversation

Zales0123
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

😱

@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Feb 8, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner February 8, 2019 14:30
@lchrusciel lchrusciel merged commit b126174 into Sylius:master Feb 11, 2019
@lchrusciel
Copy link
Member

Thank you, Mateusz! 🎉

@stefandoorn
Copy link
Contributor

May be a good one to have tests to check migrations.. :-) I copy pasted the uses etc. from another migration, but that was on 1.2 I think.

@Zales0123
Copy link
Member Author

Well, in fact, there is a test - using them to build a database on Travis https://github.com/Sylius/Sylius/blob/master/etc/travis/suites/application/before_script.sh#L10 😄 and it was the reason why the build was failing

@stefandoorn
Copy link
Contributor

Oeps, I didn't say anything :D

@Zales0123 Zales0123 deleted the fix-migration branch February 11, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zales0123 @lchrusciel @stefandoorn