[Behat][Shop] Wait for province form loading #10363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Potential Bug
bartoszpietrzak1994
approved these changes
May 8, 2019
lchrusciel
approved these changes
May 8, 2019
|
Thanks, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time, we're experiencing some random build fails. I've detected that most (if not all) of them are related to two scenarios:
features/checkout/addressing_order/choosing_province_for_country.featureandfeatures/checkout/addressing_order/specifying_province_manually.feature.The problem is, ajax is used to load a proper province form but it does not add loader spinner to the form (which prevents from any modifications until loading is ended).
I believe a proposed fix can improve these tests to lower the number of randomly failing builds. On the other hand, I consider it as a hotfix, it would be great to set a first available country as a default one and select a proper province field for it (to not load form by ajax on