Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion: Rule value disappears on rule type change #10413

Open
igormukhingmailcom opened this issue May 28, 2019 · 4 comments
Open

Promotion: Rule value disappears on rule type change #10413

igormukhingmailcom opened this issue May 28, 2019 · 4 comments
Labels
Admin AdminBundle related issues and PRs. Do not stale Important issues and PRs, that should not be stalled by Stale Bot Future Issues and PRs which are blocked by outside constraints. UX Issues and PRs aimed at improving User eXperience.

Comments

@igormukhingmailcom
Copy link
Contributor

Sylius version affected: 1.3 (at least, but I guess any)

Description
When we change rule type at promotion add/change admin form, configuration values(-s) no longer displayed.

Steps to reproduce

  • Open any promotion http://localhost:8000/admin/promotions/1/edit
  • Remember what Rule Type was and what configuration value(-s) was (lets define them as initial)
  • Change Rule Type to any other
  • Change Rule Type back to initial
  • Configuration value(-s) not restoring (configuration field(-s) is blank) <---- ISSUE

Possible Solution
Not sure. Some JS handler should be called on Rule Type change I guess, not only on page load.

@Zales0123 Zales0123 added Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience. labels Jun 10, 2019
@Zales0123 Zales0123 assigned Zales0123 and unassigned Zales0123 Jun 10, 2019
@Zales0123
Copy link
Member

@kulczy do you think it can be somehow resolved on a js level?

@igormukhingmailcom
Copy link
Contributor Author

igormukhingmailcom commented Jun 10, 2019 via email

@kulczy
Copy link
Member

kulczy commented Jul 15, 2019

Hi, @igormukhingmailcom thanks for reporting. I have no doubt that this is useful and we will probably think about it in the future, but we currently have things with a higher priority

@CoderMaggie CoderMaggie added the Future Issues and PRs which are blocked by outside constraints. label Jul 18, 2019
@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Oct 16, 2019
@Zales0123 Zales0123 added Do not stale Important issues and PRs, that should not be stalled by Stale Bot and removed Stale Issues and PRs with no recent activity, about to be closed soon. labels Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Do not stale Important issues and PRs, that should not be stalled by Stale Bot Future Issues and PRs which are blocked by outside constraints. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

No branches or pull requests

4 participants