-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Administrator's avatar #10449
Merged
Merged
Administrator's avatar #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
suggested changes
Jun 12, 2019
AdamKasp
reviewed
Jun 13, 2019
src/Sylius/Behat/Context/Ui/Admin/ManagingAdministratorsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingAdministratorsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingAdministratorsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingAdministratorsContext.php
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Jun 13, 2019
pamil
suggested changes
Jun 13, 2019
src/Sylius/Bundle/CoreBundle/Resources/config/doctrine/model/AdminUser.orm.xml
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Jun 13, 2019
src/Sylius/Bundle/CoreBundle/Resources/config/doctrine/model/AdminUser.orm.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/UiBundle/Resources/translations/messages.en.yml
Outdated
Show resolved
Hide resolved
I think you should squash some commits. |
2e83050
to
97153d6
Compare
CoderMaggie
requested changes
Jun 13, 2019
src/Sylius/Bundle/UiBundle/Resources/translations/messages.en.yml
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/adding_avatar_to_administrator.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
095a44d
to
81157be
Compare
GSadee
requested changes
Jun 13, 2019
features/user/managing_administrators/adding_avatar_to_administrator.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/adding_avatar_to_administrator.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Page/Admin/Administrator/UpdatePageInterface.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/AdminUser/_form.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/EventListener/AvatarUploaderListener.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/EventListener/AvatarUploaderListener.php
Outdated
Show resolved
Hide resolved
loic425
requested changes
Jun 14, 2019
8c1b74f
to
075a9d9
Compare
CoderMaggie
reviewed
Jun 14, 2019
src/Sylius/Behat/Context/Ui/Admin/ManagingAdministratorsContext.php
Outdated
Show resolved
Hide resolved
075a9d9
to
1b01b75
Compare
GSadee
approved these changes
Jun 17, 2019
features/user/managing_administrators/changing_administrator_avatar.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/EventListener/ImageUploadListenerSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
Jun 17, 2019
CoderMaggie
requested changes
Jun 17, 2019
src/Sylius/Bundle/AdminBundle/Resources/views/AdminUser/_media.html.twig
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Jun 17, 2019
da78606
to
33e81f0
Compare
CoderMaggie
approved these changes
Jun 17, 2019
Thank you, Tomasz and Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main bar after added avatar:
![Zrzut ekranu 2019-06-17 o 08 47 45](https://user-images.githubusercontent.com/6212718/59588485-fbed7880-90e7-11e9-937e-dba4b87e6e7a.png)
Avatar in admin form:
![Zrzut ekranu 2019-06-17 o 08 47 41](https://user-images.githubusercontent.com/6212718/59588494-00b22c80-90e8-11e9-8db6-b0082270093f.png)