Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to follow Symfony 4 standards #10473

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Update docs to follow Symfony 4 standards #10473

merged 2 commits into from
Jun 27, 2019

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jun 27, 2019 •
edited
Loading

  • Left outdated documentation intact.
  • Two articles removed because they're not technically possible with our current stack
  • Some articles marked as outdated, it's possible to update them but it'd require much more work

@pamil pamil requested a review from a team as a code owner June 27, 2019 06:19
@pamil pamil added Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc. labels Jun 27, 2019
lchrusciel
lchrusciel reviewed Jun 27, 2019
View reviewed changes
docs/components_and_bundles/bundles/SyliusGridBundle/your_first_grid.rst Outdated Show resolved Hide resolved
docs/components_and_bundles/bundles/SyliusMailerBundle/using_custom_adapter.rst Show resolved Hide resolved
docs/components_and_bundles/bundles/SyliusMailerBundle/your_first_email.rst Outdated Show resolved Hide resolved
docs/cookbook/deployment/platform-sh-advanced.rst
Advanced Platform.sh configurations
===================================

.. danger::

We're sorry but **this documentation section is outdated**. Please have that in mind when trying to use it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

It's not outdated much, but we should review both sections

docs/cookbook/entities/custom-translatable-model.rst Outdated Show resolved Hide resolved
@lchrusciel
Copy link
Member

Thank you, Kamil! 🥇

@lchrusciel lchrusciel merged commit f9b9911 into Sylius:1.4 Jun 27, 2019
@pamil pamil deleted the 1.4-docs-sf4 branch June 27, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@CoderMaggie CoderMaggie CoderMaggie approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pamil @lchrusciel @CoderMaggie