"Customer can login to the store" checkbox bug in the customer admin

[mikemix]

Sylius version affected: 1.6.2

Description
Even though customer has an account, the "user can login" checkbox is not checked.

Steps to reproduce

1. Go to the customer admin
2. Type: first name, last name and the email, DON'T check the "user can login" checkbox
3. Press save and wait for the page to reload
4. Check user can login checkbox, type a password and press save
5. Notice the checkbox is NOT checked

When you check it, the form disappears LOL ! This bug makes my clients go crazy.

[mikemix]

Bug spotted! In the @SyliusAdmin/Customer/_form.html.twig you have:

{% if customer.user is empty or customer.user.id is null %}

The empty test will always return true if the account exists! From the documentation:

For objects that implement the __toString() magic method (and not Countable), it will check if an empty string is returned.

Should be:

{% if customer.user is null or customer.user.id is null %}

or simply

{% if customer.user.id|default() %}

[Zales0123]

Indeed there is a bug. Are you willing to open a PR with the fix? Regarding a test, we should probably add some scenario in this file, with some new step like And customer should be able to log in to the store with the checkbox check

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.