[Documentation] Sylius Plus docs part 2; including fixes to links #11177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CoderMaggie
commented
Mar 4, 2020
CoderMaggie
commented
| Q | A |
|---|---|
| Branch? | 1.6 |
| Doc fix? | yes - broken links for The Book |
| New docs? | yes |
| Related tickets | Part 2 of #11054 |
| License | MIT |
GSadee
reviewed
Mar 5, 2020
| * :doc:`/book/customers/customer_and_shopuser` |
There was a problem hiding this comment.
Suggested change
| * :doc:`/book/customers/customer_and_shopuser` | |
| * :doc:`/book/customers/customer_and_shop_user` |
? 😄
There was a problem hiding this comment.
the file is named like that already, can be changed but ina different PR.
| * :doc:`/book/customers/customer_and_shopuser` | ||
| * :doc:`/book/customers/customer_pools` | ||
| * :doc:`/book/customers/adminuser` |
There was a problem hiding this comment.
Suggested change
| * :doc:`/book/customers/adminuser` | |
| * :doc:`/book/customers/admin_user` |
There was a problem hiding this comment.
sorry, it's the filename, I cannot change it in the scope of this PR.
| <li><p><a class="reference internal" href="orders/refunds.html"><span class="doc">Refunds</span></a></p></li> | ||
| </ul> | ||
| * :doc:`/book/orders/orders` | ||
| * :doc:`/book/orders/cart-flow` |
There was a problem hiding this comment.
So what convention do we have? - or _?
There was a problem hiding this comment.
_ in general, but there are some mistakes in the filenames made previously.
GSadee
approved these changes
Mar 5, 2020
GSadee
added
the
Documentation
|
Thanks, Magdalena! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.